Message ID | 1594266433-21621-1-git-send-email-zhengchuan@huawei.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | migration: fix memory leak in qmp_migrate_set_parameters | expand |
Patchew URL: https://patchew.org/QEMU/1594266433-21621-1-git-send-email-zhengchuan@huawei.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash make docker-image-centos7 V=1 NETWORK=1 time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1 === TEST SCRIPT END === TEST check-qtest-aarch64: tests/qtest/boot-serial-test TEST check-unit: tests/test-iov TEST check-qtest-aarch64: tests/qtest/migration-test *** Error in `aarch64-softmmu/qemu-system-aarch64': malloc(): smallbin double linked list corrupted: 0x000055573094ba50 *** ======= Backtrace: ========= /lib64/libc.so.6(+0x7f3e4)[0x7f91ffa203e4] /lib64/libc.so.6(+0x82b20)[0x7f91ffa23b20] --- ffffffffff600000-ffffffffff601000 r-xp 00000000 00:00 0 [vsyscall] Broken pipe /tmp/qemu-test/src/tests/qtest/libqtest.c:175: kill_qemu() detected QEMU death from signal 6 (Aborted) (core dumped) ERROR - too few tests run (expected 17, got 0) make: *** [check-qtest-aarch64] Error 1 make: *** Waiting for unfinished jobs.... TEST check-unit: tests/test-bitmap TEST check-unit: tests/test-aio --- TEST check-qtest-x86_64: tests/qtest/test-filter-mirror TEST check-qtest-x86_64: tests/qtest/test-filter-redirector TEST check-qtest-x86_64: tests/qtest/migration-test *** Error in `x86_64-softmmu/qemu-system-x86_64': malloc(): smallbin double linked list corrupted: 0x000055acb436fc20 *** ======= Backtrace: ========= /lib64/libc.so.6(+0x7f3e4)[0x7fe7408803e4] /lib64/libc.so.6(+0x82b20)[0x7fe740883b20] --- ffffffffff600000-ffffffffff601000 r-xp 00000000 00:00 0 [vsyscall] Broken pipe /tmp/qemu-test/src/tests/qtest/libqtest.c:175: kill_qemu() detected QEMU death from signal 6 (Aborted) (core dumped) ERROR - too few tests run (expected 17, got 0) make: *** [check-qtest-x86_64] Error 1 TEST iotest-qcow2: 040 TEST iotest-qcow2: 041 TEST iotest-qcow2: 042 --- Not run: 259 Failures: 181 Failed 1 of 119 iotests make: *** [check-tests/check-block.sh] Error 1 Traceback (most recent call last): File "./tests/docker/docker.py", line 669, in <module> sys.exit(main()) --- raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=3acbdaa9eced4b7c8e7cca8159422d78', '-u', '1001', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-re3_8n35/src/docker-src.2020-07-09-00.28.42.1742:/var/tmp/qemu:z,ro', 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2. filter=--filter=label=com.qemu.instance.uuid=3acbdaa9eced4b7c8e7cca8159422d78 make[1]: *** [docker-run] Error 1 make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-re3_8n35/src' make: *** [docker-run-test-quick@centos7] Error 2 real 16m47.593s user 0m9.152s The full log is available at http://patchew.org/logs/1594266433-21621-1-git-send-email-zhengchuan@huawei.com/testing.docker-quick@centos7/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
diff --git a/migration/migration.c b/migration/migration.c index 92e44e0..6edee04 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -1529,10 +1529,13 @@ void qmp_migrate_set_parameters(MigrateSetParameters *params, Error **errp) if (!migrate_params_check(&tmp, errp)) { /* Invalid parameter */ - return; + goto out; } migrate_params_apply(params, errp); +out: + g_free(tmp.tls_hostname); + g_free(tmp.tls_creds); }