diff mbox series

migration/dirtyrate: simplify inlcudes in dirtyrate.c

Message ID 1604030281-112946-1-git-send-email-zhengchuan@huawei.com (mailing list archive)
State New, archived
Headers show
Series migration/dirtyrate: simplify inlcudes in dirtyrate.c | expand

Commit Message

Zheng Chuan Oct. 30, 2020, 3:58 a.m. UTC
Remove redundant blank line which is left by Commit 662770af7c6e8c,
also take this opportunity to remove redundant includes in dirtyrate.c.

Signed-off-by: Chuan Zheng <zhengchuan@huawei.com>
---
 migration/dirtyrate.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Mark Kanda Oct. 30, 2020, 2:09 p.m. UTC | #1
On 10/29/2020 10:58 PM, Chuan Zheng wrote:
> Remove redundant blank line which is left by Commit 662770af7c6e8c,
> also take this opportunity to remove redundant includes in dirtyrate.c.
> 
> Signed-off-by: Chuan Zheng <zhengchuan@huawei.com>

Reviewed-by: Mark Kanda <mark.kanda@oracle.com>

> ---
>   migration/dirtyrate.c | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
> index 8f728d2..ccb9814 100644
> --- a/migration/dirtyrate.c
> +++ b/migration/dirtyrate.c
> @@ -11,17 +11,12 @@
>    */
>   
>   #include "qemu/osdep.h"
> -
>   #include <zlib.h>
>   #include "qapi/error.h"
>   #include "cpu.h"
> -#include "qemu/config-file.h"
> -#include "exec/memory.h"
>   #include "exec/ramblock.h"
> -#include "exec/target_page.h"
>   #include "qemu/rcu_queue.h"
>   #include "qapi/qapi-commands-migration.h"
> -#include "migration.h"
>   #include "ram.h"
>   #include "trace.h"
>   #include "dirtyrate.h"
>
Zheng Chuan Nov. 6, 2020, 6:24 a.m. UTC | #2
Kindly ping for not forgetting this trivial fix:)

On 2020/10/30 22:09, Mark Kanda wrote:
> On 10/29/2020 10:58 PM, Chuan Zheng wrote:
>> Remove redundant blank line which is left by Commit 662770af7c6e8c,
>> also take this opportunity to remove redundant includes in dirtyrate.c.
>>
>> Signed-off-by: Chuan Zheng <zhengchuan@huawei.com>
> 
> Reviewed-by: Mark Kanda <mark.kanda@oracle.com>
> 
>> ---
>>   migration/dirtyrate.c | 5 -----
>>   1 file changed, 5 deletions(-)
>>
>> diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
>> index 8f728d2..ccb9814 100644
>> --- a/migration/dirtyrate.c
>> +++ b/migration/dirtyrate.c
>> @@ -11,17 +11,12 @@
>>    */
>>     #include "qemu/osdep.h"
>> -
>>   #include <zlib.h>
>>   #include "qapi/error.h"
>>   #include "cpu.h"
>> -#include "qemu/config-file.h"
>> -#include "exec/memory.h"
>>   #include "exec/ramblock.h"
>> -#include "exec/target_page.h"
>>   #include "qemu/rcu_queue.h"
>>   #include "qapi/qapi-commands-migration.h"
>> -#include "migration.h"
>>   #include "ram.h"
>>   #include "trace.h"
>>   #include "dirtyrate.h"
>>
Dr. David Alan Gilbert Nov. 6, 2020, 4:53 p.m. UTC | #3
* Zheng Chuan (zhengchuan@huawei.com) wrote:
> Kindly ping for not forgetting this trivial fix:)

Yes but it's too late for the merge window, so it'll happen on the next
one, no rush!

Dave

> On 2020/10/30 22:09, Mark Kanda wrote:
> > On 10/29/2020 10:58 PM, Chuan Zheng wrote:
> >> Remove redundant blank line which is left by Commit 662770af7c6e8c,
> >> also take this opportunity to remove redundant includes in dirtyrate.c.
> >>
> >> Signed-off-by: Chuan Zheng <zhengchuan@huawei.com>
> > 
> > Reviewed-by: Mark Kanda <mark.kanda@oracle.com>
> > 
> >> ---
> >>   migration/dirtyrate.c | 5 -----
> >>   1 file changed, 5 deletions(-)
> >>
> >> diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
> >> index 8f728d2..ccb9814 100644
> >> --- a/migration/dirtyrate.c
> >> +++ b/migration/dirtyrate.c
> >> @@ -11,17 +11,12 @@
> >>    */
> >>     #include "qemu/osdep.h"
> >> -
> >>   #include <zlib.h>
> >>   #include "qapi/error.h"
> >>   #include "cpu.h"
> >> -#include "qemu/config-file.h"
> >> -#include "exec/memory.h"
> >>   #include "exec/ramblock.h"
> >> -#include "exec/target_page.h"
> >>   #include "qemu/rcu_queue.h"
> >>   #include "qapi/qapi-commands-migration.h"
> >> -#include "migration.h"
> >>   #include "ram.h"
> >>   #include "trace.h"
> >>   #include "dirtyrate.h"
> >>
> 
> -- 
> Regards.
> Chuan
>
Dr. David Alan Gilbert Nov. 12, 2020, 2:55 p.m. UTC | #4
* Chuan Zheng (zhengchuan@huawei.com) wrote:
> Remove redundant blank line which is left by Commit 662770af7c6e8c,
> also take this opportunity to remove redundant includes in dirtyrate.c.
> 
> Signed-off-by: Chuan Zheng <zhengchuan@huawei.com>

and queued

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

> ---
>  migration/dirtyrate.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
> index 8f728d2..ccb9814 100644
> --- a/migration/dirtyrate.c
> +++ b/migration/dirtyrate.c
> @@ -11,17 +11,12 @@
>   */
>  
>  #include "qemu/osdep.h"
> -
>  #include <zlib.h>
>  #include "qapi/error.h"
>  #include "cpu.h"
> -#include "qemu/config-file.h"
> -#include "exec/memory.h"
>  #include "exec/ramblock.h"
> -#include "exec/target_page.h"
>  #include "qemu/rcu_queue.h"
>  #include "qapi/qapi-commands-migration.h"
> -#include "migration.h"
>  #include "ram.h"
>  #include "trace.h"
>  #include "dirtyrate.h"
> -- 
> 1.8.3.1
> 
>
diff mbox series

Patch

diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
index 8f728d2..ccb9814 100644
--- a/migration/dirtyrate.c
+++ b/migration/dirtyrate.c
@@ -11,17 +11,12 @@ 
  */
 
 #include "qemu/osdep.h"
-
 #include <zlib.h>
 #include "qapi/error.h"
 #include "cpu.h"
-#include "qemu/config-file.h"
-#include "exec/memory.h"
 #include "exec/ramblock.h"
-#include "exec/target_page.h"
 #include "qemu/rcu_queue.h"
 #include "qapi/qapi-commands-migration.h"
-#include "migration.h"
 #include "ram.h"
 #include "trace.h"
 #include "dirtyrate.h"