From patchwork Mon Nov 9 18:56:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alex Williamson X-Patchwork-Id: 11892283 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EADF71130 for ; Mon, 9 Nov 2020 18:57:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 850C7206D8 for ; Mon, 9 Nov 2020 18:57:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AphrmjOy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 850C7206D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:39112 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcCM2-0003wx-FJ for patchwork-qemu-devel@patchwork.kernel.org; Mon, 09 Nov 2020 13:57:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58030) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcCKy-00034S-AQ for qemu-devel@nongnu.org; Mon, 09 Nov 2020 13:56:20 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:55834) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kcCKu-0003W2-9m for qemu-devel@nongnu.org; Mon, 09 Nov 2020 13:56:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604948173; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=39Vz5xwcf5ftMWX/kvXd3/2gTZkN2mIj5A51OZpR0Nw=; b=AphrmjOyOZiz+m6Gc/1b/OO5baBMmQs0aIm+Zn7ucdhxZopGjIhK4FUSBjQcvrxpVLw61L QQ43fKs4xbX5LI9oE4XsNQGfFmtaqBfcUqEM1Rsms2XRz2NxP20+OW7KWLZ7C016xNWO7+ AlpQMD509QPPm9yC64dUGxuIu2Burto= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-262-DNVUhddbOxm7meyMBT5YVQ-1; Mon, 09 Nov 2020 13:56:10 -0500 X-MC-Unique: DNVUhddbOxm7meyMBT5YVQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E81B134912; Mon, 9 Nov 2020 18:56:08 +0000 (UTC) Received: from gimli.home (ovpn-112-213.phx2.redhat.com [10.3.112.213]) by smtp.corp.redhat.com (Postfix) with ESMTP id 63B1360E1C; Mon, 9 Nov 2020 18:56:03 +0000 (UTC) Subject: [RFC PATCH for-QEMU-5.2] vfio: Make migration support experimental From: Alex Williamson To: qemu-devel@nongnu.org Date: Mon, 09 Nov 2020 11:56:02 -0700 Message-ID: <160494787833.1473.10514376876696596117.stgit@gimli.home> User-Agent: StGit/0.21-dirty MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=alex.williamson@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=63.128.21.124; envelope-from=alex.williamson@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/09 01:25:23 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neo Jia , Juan Quintela , Cornelia Huck , "Dr. David Alan Gilbert" , Kirti Wankhede , Philippe =?utf-8?q?Mathieu-Daud?= =?utf-8?q?=C3=A9?= Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" Per the proposed documentation for vfio device migration: Dirty pages are tracked when device is in stop-and-copy phase because if pages are marked dirty during pre-copy phase and content is transfered from source to destination, there is no way to know newly dirtied pages from the point they were copied earlier until device stops. To avoid repeated copy of same content, pinned pages are marked dirty only during stop-and-copy phase. Essentially, since we don't have hardware dirty page tracking for assigned devices at this point, we consider any page that is pinned by an mdev vendor driver or pinned and mapped through the IOMMU to be perpetually dirty. In the worst case, this may result in all of guest memory being considered dirty during every iteration of live migration. The current vfio implementation of migration has chosen to mask device dirtied pages until the final stages of migration in order to avoid this worst case scenario. Allowing the device to implement a policy decision to prioritize reduced migration data like this jeopardizes QEMU's overall ability to implement any degree of service level guarantees during migration. For example, any estimates towards achieving acceptable downtime margins cannot be trusted when such a device is present. The vfio device should participate in dirty page tracking to the best of its ability throughout migration, even if that means the dirty footprint of the device impedes migration progress, allowing both QEMU and higher level management tools to decide whether to continue the migration or abort due to failure to achieve the desired behavior. Link: https://lists.gnu.org/archive/html/qemu-devel/2020-11/msg00807.html Cc: Kirti Wankhede Cc: Neo Jia Cc: Dr. David Alan Gilbert Cc: Juan Quintela Cc: Philippe Mathieu-Daudé Cc: Cornelia Huck Signed-off-by: Alex Williamson Reviewed-by: Dr. David Alan Gilbert Acked-by: Cornelia Huck --- Given that our discussion in the link above seems to be going in circles, I'm afraid it seems necessary to both have a contigency plan and to raise the visibility of the current behavior to determine whether others agree that this is a sufficiently troubling behavior to consider migration support experimental at this stage. Please voice your opinion or contribute patches to resolve this before QEMU 5.2. Thanks, Alex hw/vfio/migration.c | 2 +- hw/vfio/pci.c | 2 ++ include/hw/vfio/vfio-common.h | 1 + 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c index 3ce285ea395d..cd44d465a50b 100644 --- a/hw/vfio/migration.c +++ b/hw/vfio/migration.c @@ -882,7 +882,7 @@ int vfio_migration_probe(VFIODevice *vbasedev, Error **errp) Error *local_err = NULL; int ret = -ENOTSUP; - if (!container->dirty_pages_supported) { + if (!vbasedev->enable_migration || !container->dirty_pages_supported) { goto add_blocker; } diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 58c0ce8971e3..1349b900e513 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -3194,6 +3194,8 @@ static Property vfio_pci_dev_properties[] = { VFIO_FEATURE_ENABLE_REQ_BIT, true), DEFINE_PROP_BIT("x-igd-opregion", VFIOPCIDevice, features, VFIO_FEATURE_ENABLE_IGD_OPREGION_BIT, false), + DEFINE_PROP_BOOL("x-enable-migration", VFIOPCIDevice, + vbasedev.enable_migration, false), DEFINE_PROP_BOOL("x-no-mmap", VFIOPCIDevice, vbasedev.no_mmap, false), DEFINE_PROP_BOOL("x-balloon-allowed", VFIOPCIDevice, vbasedev.ram_block_discard_allowed, false), diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-common.h index baeb4dcff102..2119872c8af1 100644 --- a/include/hw/vfio/vfio-common.h +++ b/include/hw/vfio/vfio-common.h @@ -123,6 +123,7 @@ typedef struct VFIODevice { bool needs_reset; bool no_mmap; bool ram_block_discard_allowed; + bool enable_migration; VFIODeviceOps *ops; unsigned int num_irqs; unsigned int num_regions;