| Message ID | 1612339311-114805-8-git-send-email-zhengchuan@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Support Multifd for RDMA migration | expand |
* Chuan Zheng (zhengchuan@huawei.com) wrote: > Note we do want to export any rdma struct, take void * instead. You don't need to make this a void *; add a typedef struct RDMAContext into include/qemu/typedefs.h and then you can use the right type here without actually exporting the interesting contents of the type or being dependent on rdma being built. Dave > Signed-off-by: Chuan Zheng <zhengchuan@huawei.com> > --- > migration/multifd.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/migration/multifd.h b/migration/multifd.h > index d57756c..b17a2c1 100644 > --- a/migration/multifd.h > +++ b/migration/multifd.h > @@ -108,6 +108,10 @@ typedef struct { > QemuSemaphore sem_sync; > /* used for compression methods */ > void *data; > + /* used for multifd rdma */ > + void *rdma; > + /* communication channel */ > + QEMUFile *file; > } MultiFDSendParams; > > typedef struct { > @@ -147,6 +151,10 @@ typedef struct { > QemuSemaphore sem_sync; > /* used for de-compression methods */ > void *data; > + /* used for multifd rdma */ > + void *rdma; > + /* communication channel */ > + QEMUFile *file; > } MultiFDRecvParams; > > typedef struct { > -- > 1.8.3.1 >
On 2021/2/4 2:32, Dr. David Alan Gilbert wrote: > * Chuan Zheng (zhengchuan@huawei.com) wrote: >> Note we do want to export any rdma struct, take void * instead. > > You don't need to make this a void *; add a typedef struct RDMAContext > into include/qemu/typedefs.h and then you can use the right type here > without actually exporting the interesting contents of the type or > being dependent on rdma being built. > > Dave > OK, good to know it, will do it in v5. >> Signed-off-by: Chuan Zheng <zhengchuan@huawei.com> >> --- >> migration/multifd.h | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/migration/multifd.h b/migration/multifd.h >> index d57756c..b17a2c1 100644 >> --- a/migration/multifd.h >> +++ b/migration/multifd.h >> @@ -108,6 +108,10 @@ typedef struct { >> QemuSemaphore sem_sync; >> /* used for compression methods */ >> void *data; >> + /* used for multifd rdma */ >> + void *rdma; >> + /* communication channel */ >> + QEMUFile *file; >> } MultiFDSendParams; >> >> typedef struct { >> @@ -147,6 +151,10 @@ typedef struct { >> QemuSemaphore sem_sync; >> /* used for de-compression methods */ >> void *data; >> + /* used for multifd rdma */ >> + void *rdma; >> + /* communication channel */ >> + QEMUFile *file; >> } MultiFDRecvParams; >> >> typedef struct { >> -- >> 1.8.3.1 >>
diff --git a/migration/multifd.h b/migration/multifd.h index d57756c..b17a2c1 100644 --- a/migration/multifd.h +++ b/migration/multifd.h @@ -108,6 +108,10 @@ typedef struct { QemuSemaphore sem_sync; /* used for compression methods */ void *data; + /* used for multifd rdma */ + void *rdma; + /* communication channel */ + QEMUFile *file; } MultiFDSendParams; typedef struct { @@ -147,6 +151,10 @@ typedef struct { QemuSemaphore sem_sync; /* used for de-compression methods */ void *data; + /* used for multifd rdma */ + void *rdma; + /* communication channel */ + QEMUFile *file; } MultiFDRecvParams; typedef struct {
Note we do want to export any rdma struct, take void * instead. Signed-off-by: Chuan Zheng <zhengchuan@huawei.com> --- migration/multifd.h | 8 ++++++++ 1 file changed, 8 insertions(+)