| Message ID | 1613741973-3711-2-git-send-email-pmorel@linux.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | css: SCHIB measurement block origin must be aligned | expand |
On 19/02/2021 14.39, Pierre Morel wrote: > The Measurement Block Origin inside the SCHIB is used when > Measurement Block format 1 is in used and must be aligned > on 64 bytes otherwise an operand exception is recognized > when issuing the Modify Sub CHannel (MSCH) instruction. > > Signed-off-by: Pierre Morel <pmorel@linux.ibm.com> > --- > target/s390x/ioinst.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/target/s390x/ioinst.c b/target/s390x/ioinst.c > index a412926d27..1ee11522e1 100644 > --- a/target/s390x/ioinst.c > +++ b/target/s390x/ioinst.c > @@ -121,6 +121,12 @@ static int ioinst_schib_valid(SCHIB *schib) > if (be32_to_cpu(schib->pmcw.chars) & PMCW_CHARS_MASK_XMWME) { > return 0; > } > + /* for MB format 1 bits 26-31 of word 11 must be 0 */ > + /* MBA uses words 10 and 11, it means align on 2**6 */ > + if ((be16_to_cpu(schib->pmcw.chars) & PMCW_CHARS_MASK_MBFC) && > + (be64_to_cpu(schib->mba) & 0x03fUL)) { > + return 0; > + } > return 1; > } Reviewed-by: Thomas Huth <thuth@redhat.com>
On 2/19/21 2:41 PM, Thomas Huth wrote: > On 19/02/2021 14.39, Pierre Morel wrote: >> The Measurement Block Origin inside the SCHIB is used when >> Measurement Block format 1 is in used and must be aligned >> on 64 bytes otherwise an operand exception is recognized >> when issuing the Modify Sub CHannel (MSCH) instruction. >> >> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com> >> --- >> target/s390x/ioinst.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/target/s390x/ioinst.c b/target/s390x/ioinst.c >> index a412926d27..1ee11522e1 100644 >> --- a/target/s390x/ioinst.c >> +++ b/target/s390x/ioinst.c >> @@ -121,6 +121,12 @@ static int ioinst_schib_valid(SCHIB *schib) >> if (be32_to_cpu(schib->pmcw.chars) & PMCW_CHARS_MASK_XMWME) { >> return 0; >> } >> + /* for MB format 1 bits 26-31 of word 11 must be 0 */ >> + /* MBA uses words 10 and 11, it means align on 2**6 */ >> + if ((be16_to_cpu(schib->pmcw.chars) & PMCW_CHARS_MASK_MBFC) && >> + (be64_to_cpu(schib->mba) & 0x03fUL)) { >> + return 0; >> + } >> return 1; >> } > > Reviewed-by: Thomas Huth <thuth@redhat.com> > Thanks, Pierre
diff --git a/target/s390x/ioinst.c b/target/s390x/ioinst.c index a412926d27..1ee11522e1 100644 --- a/target/s390x/ioinst.c +++ b/target/s390x/ioinst.c @@ -121,6 +121,12 @@ static int ioinst_schib_valid(SCHIB *schib) if (be32_to_cpu(schib->pmcw.chars) & PMCW_CHARS_MASK_XMWME) { return 0; } + /* for MB format 1 bits 26-31 of word 11 must be 0 */ + /* MBA uses words 10 and 11, it means align on 2**6 */ + if ((be16_to_cpu(schib->pmcw.chars) & PMCW_CHARS_MASK_MBFC) && + (be64_to_cpu(schib->mba) & 0x03fUL)) { + return 0; + } return 1; }
The Measurement Block Origin inside the SCHIB is used when Measurement Block format 1 is in used and must be aligned on 64 bytes otherwise an operand exception is recognized when issuing the Modify Sub CHannel (MSCH) instruction. Signed-off-by: Pierre Morel <pmorel@linux.ibm.com> --- target/s390x/ioinst.c | 6 ++++++ 1 file changed, 6 insertions(+)