Message ID | 161572198360.18482.17163668289458544283.malone@soybean.canonical.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | [Bug,1919036] Re: Assertion failure in fifo8_push_all() through am53c974 | expand |
Patchew URL: https://patchew.org/QEMU/161572198360.18482.17163668289458544283.malone@soybean.canonical.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 161572198360.18482.17163668289458544283.malone@soybean.canonical.com Subject: [Bug 1919036] Re: Assertion failure in fifo8_push_all() through am53c974 === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu 3f8d188..8e6bc6c master -> master * [new tag] patchew/161572198360.18482.17163668289458544283.malone@soybean.canonical.com -> patchew/161572198360.18482.17163668289458544283.malone@soybean.canonical.com Switched to a new branch 'test' adbf373 Assertion failure in fifo8_push_all() through am53c974 === OUTPUT BEGIN === ERROR: Missing Signed-off-by: line(s) total: 1 errors, 0 warnings, 7 lines checked Commit adbf373a9928 (Assertion failure in fifo8_push_all() through am53c974) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/161572198360.18482.17163668289458544283.malone@soybean.canonical.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c index 507ab363bc..0a26ee1dfd 100644 --- a/hw/scsi/esp.c +++ b/hw/scsi/esp.c @@ -573,6 +573,7 @@ static void esp_do_dma(ESPState *s) cmdlen = fifo8_num_used(&s->cmdfifo); trace_esp_do_dma(cmdlen, len); if (s->dma_memory_read) { + len = MIN(len, fifo8_num_free(&s->cmdfifo)); s->dma_memory_read(s->dma_opaque, buf, len); fifo8_push_all(&s->cmdfifo, buf, len); } else {