[PULL,V2,0/3] Net patches

Message ID	1622089478-5426-1-git-send-email-jasowang@redhat.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <SRS0=ExN+=KW=nongnu.org=qemu-devel-bounces+qemu-devel=archiver.kernel.org@kernel.org> DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A420613BC From: Jason Wang <jasowang@redhat.com> To: peter.maydell@linaro.org Subject: [PULL V2 0/3] Net patches Date: Thu, 27 May 2021 12:24:35 +0800 Message-Id: <1622089478-5426-1-git-send-email-jasowang@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.371, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action Precedence: list Cc: Jason Wang <jasowang@redhat.com>, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org>

Jason Wang May 27, 2021, 4:24 a.m. UTC

The following changes since commit d90f154867ec0ec22fd719164b88716e8fd48672:

  Merge remote-tracking branch 'remotes/dg-gitlab/tags/ppc-for-6.1-20210504' into staging (2021-05-05 20:29:14 +0100)

are available in the git repository at:

  https://github.com/jasowang/qemu.git tags/net-pull-request

for you to fetch changes up to 4f8a39494aded9f2026a26b137378ea2ee3d5338:

  tap-bsd: Remove special casing for older OpenBSD releases (2021-05-27 11:03:55 +0800)

----------------------------------------------------------------

----------------------------------------------------------------
Brad Smith (1):
      tap-bsd: Remove special casing for older OpenBSD releases

Guenter Roeck (1):
      hw/net/imx_fec: return 0xffff when accessing non-existing PHY

Laurent Vivier (1):
      virtio-net: failover: add missing remove_migration_state_change_notifier()

 hw/net/imx_fec.c    | 8 +++-----
 hw/net/trace-events | 2 ++
 hw/net/virtio-net.c | 1 +
 net/tap-bsd.c       | 8 --------
 4 files changed, 6 insertions(+), 13 deletions(-)

Bin Meng May 27, 2021, 6:13 a.m. UTC | #1

Hi Jason,

On Thu, May 27, 2021 at 12:24 PM Jason Wang <jasowang@redhat.com> wrote:
>
> The following changes since commit d90f154867ec0ec22fd719164b88716e8fd48672:
>
>   Merge remote-tracking branch 'remotes/dg-gitlab/tags/ppc-for-6.1-20210504' into staging (2021-05-05 20:29:14 +0100)
>
> are available in the git repository at:
>
>   https://github.com/jasowang/qemu.git tags/net-pull-request
>
> for you to fetch changes up to 4f8a39494aded9f2026a26b137378ea2ee3d5338:
>
>   tap-bsd: Remove special casing for older OpenBSD releases (2021-05-27 11:03:55 +0800)
>
> ----------------------------------------------------------------
>
> ----------------------------------------------------------------
> Brad Smith (1):
>       tap-bsd: Remove special casing for older OpenBSD releases
>
> Guenter Roeck (1):
>       hw/net/imx_fec: return 0xffff when accessing non-existing PHY
>
> Laurent Vivier (1):
>       virtio-net: failover: add missing remove_migration_state_change_notifier()
>
>  hw/net/imx_fec.c    | 8 +++-----
>  hw/net/trace-events | 2 ++
>  hw/net/virtio-net.c | 1 +
>  net/tap-bsd.c       | 8 --------
>  4 files changed, 6 insertions(+), 13 deletions(-)

What happened to patch 5-12 in the following series?
http://patchwork.ozlabs.org/project/qemu-devel/cover/20210317062638.72626-1-bmeng.cn@gmail.com/

Regards,
Bin

Jason Wang May 27, 2021, 6:35 a.m. UTC | #2

在 2021/5/27 下午2:13, Bin Meng 写道:
> Hi Jason,
>
> On Thu, May 27, 2021 at 12:24 PM Jason Wang <jasowang@redhat.com> wrote:
>> The following changes since commit d90f154867ec0ec22fd719164b88716e8fd48672:
>>
>>    Merge remote-tracking branch 'remotes/dg-gitlab/tags/ppc-for-6.1-20210504' into staging (2021-05-05 20:29:14 +0100)
>>
>> are available in the git repository at:
>>
>>    https://github.com/jasowang/qemu.git tags/net-pull-request
>>
>> for you to fetch changes up to 4f8a39494aded9f2026a26b137378ea2ee3d5338:
>>
>>    tap-bsd: Remove special casing for older OpenBSD releases (2021-05-27 11:03:55 +0800)
>>
>> ----------------------------------------------------------------
>>
>> ----------------------------------------------------------------
>> Brad Smith (1):
>>        tap-bsd: Remove special casing for older OpenBSD releases
>>
>> Guenter Roeck (1):
>>        hw/net/imx_fec: return 0xffff when accessing non-existing PHY
>>
>> Laurent Vivier (1):
>>        virtio-net: failover: add missing remove_migration_state_change_notifier()
>>
>>   hw/net/imx_fec.c    | 8 +++-----
>>   hw/net/trace-events | 2 ++
>>   hw/net/virtio-net.c | 1 +
>>   net/tap-bsd.c       | 8 --------
>>   4 files changed, 6 insertions(+), 13 deletions(-)
> What happened to patch 5-12 in the following series?
> http://patchwork.ozlabs.org/project/qemu-devel/cover/20210317062638.72626-1-bmeng.cn@gmail.com/


I want to do some test before the merging. Or if possible, could you 
please write a test for this function?

Thanks


>
> Regards,
> Bin
>

Bin Meng May 27, 2021, 7:14 a.m. UTC | #3

On Thu, May 27, 2021 at 2:35 PM Jason Wang <jasowang@redhat.com> wrote:
>
>
> 在 2021/5/27 下午2:13, Bin Meng 写道:
> > Hi Jason,
> >
> > On Thu, May 27, 2021 at 12:24 PM Jason Wang <jasowang@redhat.com> wrote:
> >> The following changes since commit d90f154867ec0ec22fd719164b88716e8fd48672:
> >>
> >>    Merge remote-tracking branch 'remotes/dg-gitlab/tags/ppc-for-6.1-20210504' into staging (2021-05-05 20:29:14 +0100)
> >>
> >> are available in the git repository at:
> >>
> >>    https://github.com/jasowang/qemu.git tags/net-pull-request
> >>
> >> for you to fetch changes up to 4f8a39494aded9f2026a26b137378ea2ee3d5338:
> >>
> >>    tap-bsd: Remove special casing for older OpenBSD releases (2021-05-27 11:03:55 +0800)
> >>
> >> ----------------------------------------------------------------
> >>
> >> ----------------------------------------------------------------
> >> Brad Smith (1):
> >>        tap-bsd: Remove special casing for older OpenBSD releases
> >>
> >> Guenter Roeck (1):
> >>        hw/net/imx_fec: return 0xffff when accessing non-existing PHY
> >>
> >> Laurent Vivier (1):
> >>        virtio-net: failover: add missing remove_migration_state_change_notifier()
> >>
> >>   hw/net/imx_fec.c    | 8 +++-----
> >>   hw/net/trace-events | 2 ++
> >>   hw/net/virtio-net.c | 1 +
> >>   net/tap-bsd.c       | 8 --------
> >>   4 files changed, 6 insertions(+), 13 deletions(-)
> > What happened to patch 5-12 in the following series?
> > http://patchwork.ozlabs.org/project/qemu-devel/cover/20210317062638.72626-1-bmeng.cn@gmail.com/
>
>
> I want to do some test before the merging. Or if possible, could you
> please write a test for this function?
>

For each of these network adapter models? What kind of tests are
needed? Any pointers?

Regards,
Bin

Jason Wang May 27, 2021, 7:23 a.m. UTC | #4

在 2021/5/27 下午3:14, Bin Meng 写道:
> On Thu, May 27, 2021 at 2:35 PM Jason Wang <jasowang@redhat.com> wrote:
>>
>> 在 2021/5/27 下午2:13, Bin Meng 写道:
>>> Hi Jason,
>>>
>>> On Thu, May 27, 2021 at 12:24 PM Jason Wang <jasowang@redhat.com> wrote:
>>>> The following changes since commit d90f154867ec0ec22fd719164b88716e8fd48672:
>>>>
>>>>     Merge remote-tracking branch 'remotes/dg-gitlab/tags/ppc-for-6.1-20210504' into staging (2021-05-05 20:29:14 +0100)
>>>>
>>>> are available in the git repository at:
>>>>
>>>>     https://github.com/jasowang/qemu.git tags/net-pull-request
>>>>
>>>> for you to fetch changes up to 4f8a39494aded9f2026a26b137378ea2ee3d5338:
>>>>
>>>>     tap-bsd: Remove special casing for older OpenBSD releases (2021-05-27 11:03:55 +0800)
>>>>
>>>> ----------------------------------------------------------------
>>>>
>>>> ----------------------------------------------------------------
>>>> Brad Smith (1):
>>>>         tap-bsd: Remove special casing for older OpenBSD releases
>>>>
>>>> Guenter Roeck (1):
>>>>         hw/net/imx_fec: return 0xffff when accessing non-existing PHY
>>>>
>>>> Laurent Vivier (1):
>>>>         virtio-net: failover: add missing remove_migration_state_change_notifier()
>>>>
>>>>    hw/net/imx_fec.c    | 8 +++-----
>>>>    hw/net/trace-events | 2 ++
>>>>    hw/net/virtio-net.c | 1 +
>>>>    net/tap-bsd.c       | 8 --------
>>>>    4 files changed, 6 insertions(+), 13 deletions(-)
>>> What happened to patch 5-12 in the following series?
>>> http://patchwork.ozlabs.org/project/qemu-devel/cover/20210317062638.72626-1-bmeng.cn@gmail.com/
>>
>> I want to do some test before the merging. Or if possible, could you
>> please write a test for this function?
>>
> For each of these network adapter models?


e1000 and virtio-net should be sufficient.


>   What kind of tests are
> needed?


Test whether padding works.


>   Any pointers?


You can start to look at virtio-net-test.c.

Thanks


>
> Regards,
> Bin
>

Peter Maydell May 30, 2021, 5:33 p.m. UTC | #5

On Thu, 27 May 2021 at 05:24, Jason Wang <jasowang@redhat.com> wrote:
>
> The following changes since commit d90f154867ec0ec22fd719164b88716e8fd48672:
>
>   Merge remote-tracking branch 'remotes/dg-gitlab/tags/ppc-for-6.1-20210504' into staging (2021-05-05 20:29:14 +0100)
>
> are available in the git repository at:
>
>   https://github.com/jasowang/qemu.git tags/net-pull-request
>
> for you to fetch changes up to 4f8a39494aded9f2026a26b137378ea2ee3d5338:
>
>   tap-bsd: Remove special casing for older OpenBSD releases (2021-05-27 11:03:55 +0800)
>
> ----------------------------------------------------------------
>
> ----------------------------------------------------------------


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/6.1
for any user-visible changes.

-- PMM

[PULL,V2,0/3] Net patches

Pull-request

Message

Comments