| Message ID | 163542169727.2127597.8141772572696627329.stgit@pasha-ThinkPad-X280 (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Some watchpoint-related patches | expand |
On 10/28/21 4:48 AM, Pavel Dovgalyuk wrote: > Watchpoints that should fire after the memory access > break an execution of the current block, try to > translate current instruction into the separate block, > which then causes debug interrupt. > But cpu_interrupt can't be called in such block when > icount is enabled, because interrupts muse be allowed > explicitly. > This patch sets CF_LAST_IO flag for retranslated block, > allowing interrupt request for the last instruction. > > Signed-off-by: Pavel Dovgalyuk<Pavel.Dovgalyuk@ispras.ru> > --- > softmmu/physmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Indeed, the other such assignment, about 30 lines up, already does this. Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/softmmu/physmem.c b/softmmu/physmem.c index 94eda44459..482d80708f 100644 --- a/softmmu/physmem.c +++ b/softmmu/physmem.c @@ -946,7 +946,7 @@ void cpu_check_watchpoint(CPUState *cpu, vaddr addr, vaddr len, cpu_loop_exit(cpu); } else { /* Force execution of one insn next time. */ - cpu->cflags_next_tb = 1 | curr_cflags(cpu); + cpu->cflags_next_tb = 1 | CF_LAST_IO | curr_cflags(cpu); mmap_unlock(); cpu_loop_exit_noexc(cpu); }
Watchpoints that should fire after the memory access break an execution of the current block, try to translate current instruction into the separate block, which then causes debug interrupt. But cpu_interrupt can't be called in such block when icount is enabled, because interrupts muse be allowed explicitly. This patch sets CF_LAST_IO flag for retranslated block, allowing interrupt request for the last instruction. Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru> --- softmmu/physmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)