[qemu,1/1] vmxnet3: add mac address restore upon reset

Commit Message

~vlaomao Jan. 30, 2023, 5:28 p.m. UTC

From: VlaoMao <[e-mail]>

Changing the address with a subsequent reboot makes this address permanent until the vm is turned off
---
Signed-off-by: Vlao Mao <[e-mail]>

 hw/net/vmxnet3.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Laurent Vivier Jan. 31, 2023, 5:50 p.m. UTC | #1

Le 30/01/2023 à 18:28, ~vlaomao a écrit :
> From: VlaoMao <[e-mail]>
> 
> Changing the address with a subsequent reboot makes this address permanent until the vm is turned off
> ---
> Signed-off-by: Vlao Mao <[e-mail]>

As the Signed-off-by is part of the commit message it must be set before the signature signs ("---").

And the "From:" field must have the same value as the "Signed-off-by:" field (a space is missing in 
your "From:" field -> Vlao Mao).

Thanks,
Laurent

> 
>   hw/net/vmxnet3.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
> index 04159c822..695ca2f92 100644
> --- a/hw/net/vmxnet3.c
> +++ b/hw/net/vmxnet3.c
> @@ -1206,6 +1206,8 @@ static void vmxnet3_reset(VMXNET3State *s)
>       s->drv_shmem = 0;
>       s->tx_sop = true;
>       s->skip_current_tx_pkt = false;
> +
> +    vmxnet3_reset_mac(s);
>   }
>   
>   static void vmxnet3_update_rx_mode(VMXNET3State *s)

Patch

diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
index 04159c822..695ca2f92 100644
--- a/hw/net/vmxnet3.c
+++ b/hw/net/vmxnet3.c
@@ -1206,6 +1206,8 @@  static void vmxnet3_reset(VMXNET3State *s)
     s->drv_shmem = 0;
     s->tx_sop = true;
     s->skip_current_tx_pkt = false;
+
+    vmxnet3_reset_mac(s);
 }
 
 static void vmxnet3_update_rx_mode(VMXNET3State *s)