diff mbox

[RFC,v1,2/2] netduino2: Specify the valid CPUs

Message ID 16cf589bc0c0431fbba6bbed8d1a50b49d24e867.1504656490.git.alistair.francis@xilinx.com (mailing list archive)
State New, archived
Headers show

Commit Message

Alistair Francis Sept. 6, 2017, 12:12 a.m. UTC 
Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
---

 hw/arm/netduino2.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

KONRAD Frederic Sept. 11, 2017, 11:56 a.m. UTC | #1 
On 09/06/2017 02:12 AM, Alistair Francis wrote:
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> ---
> 
>   hw/arm/netduino2.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/hw/arm/netduino2.c b/hw/arm/netduino2.c
> index 3cfe332dd1..accca344fd 100644
> --- a/hw/arm/netduino2.c
> +++ b/hw/arm/netduino2.c
> @@ -43,8 +43,13 @@ static void netduino2_init(MachineState *machine)
>   
>   static void netduino2_machine_init(MachineClass *mc)
>   {
> +    const char *val = "cortex-m3";
> +
>       mc->desc = "Netduino 2 Machine";
>       mc->init = netduino2_init;
> +
> +    mc->valid_cpu_types = g_array_new(false, false, sizeof(char *));
> +    g_array_append_val(mc->valid_cpu_types, val);
>   }

Hi Alistair,

Nice idea! Why not adding an helper function which take a const
char** in argument?

Fred

>   
>   DEFINE_MACHINE("netduino2", netduino2_machine_init)
>
Alistair Francis Sept. 21, 2017, 11:07 p.m. UTC | #2 
On Mon, Sep 11, 2017 at 4:56 AM, KONRAD Frederic
<frederic.konrad@adacore.com> wrote:
>
>
> On 09/06/2017 02:12 AM, Alistair Francis wrote:
>>
>> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
>> ---
>>
>>   hw/arm/netduino2.c | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/hw/arm/netduino2.c b/hw/arm/netduino2.c
>> index 3cfe332dd1..accca344fd 100644
>> --- a/hw/arm/netduino2.c
>> +++ b/hw/arm/netduino2.c
>> @@ -43,8 +43,13 @@ static void netduino2_init(MachineState *machine)
>>     static void netduino2_machine_init(MachineClass *mc)
>>   {
>> +    const char *val = "cortex-m3";
>> +
>>       mc->desc = "Netduino 2 Machine";
>>       mc->init = netduino2_init;
>> +
>> +    mc->valid_cpu_types = g_array_new(false, false, sizeof(char *));
>> +    g_array_append_val(mc->valid_cpu_types, val);
>>   }
>
>
> Hi Alistair,
>
> Nice idea! Why not adding an helper function which take a const
> char** in argument?

Thanks Fred.

I'm going to send a v2 with just that :)

Thanks,
Alistair

>
> Fred
>
>>     DEFINE_MACHINE("netduino2", netduino2_machine_init)
>>
>
diff mbox

Patch

diff --git a/hw/arm/netduino2.c b/hw/arm/netduino2.c
index 3cfe332dd1..accca344fd 100644
--- a/hw/arm/netduino2.c
+++ b/hw/arm/netduino2.c
@@ -43,8 +43,13 @@  static void netduino2_init(MachineState *machine)
 
 static void netduino2_machine_init(MachineClass *mc)
 {
+    const char *val = "cortex-m3";
+
     mc->desc = "Netduino 2 Machine";
     mc->init = netduino2_init;
+
+    mc->valid_cpu_types = g_array_new(false, false, sizeof(char *));
+    g_array_append_val(mc->valid_cpu_types, val);
 }
 
 DEFINE_MACHINE("netduino2", netduino2_machine_init)