| Message ID | 1701970793-6865-36-git-send-email-si-wei.liu@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | vdpa-net: improve migration downtime through descriptor ASID and persistent IOTLB | expand |
On Thu, Dec 7, 2023 at 7:51 PM Si-Wei Liu <si-wei.liu@oracle.com> wrote: > > For better debuggability and observability. > > Signed-off-by: Si-Wei Liu <si-wei.liu@oracle.com> Reviewed-by: Eugenio Pérez <eperezma@redhat.com> > --- > net/trace-events | 3 +++ > net/vhost-vdpa.c | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git a/net/trace-events b/net/trace-events > index 823a071..aab666a 100644 > --- a/net/trace-events > +++ b/net/trace-events > @@ -23,3 +23,6 @@ colo_compare_tcp_info(const char *pkt, uint32_t seq, uint32_t ack, int hdlen, in > # filter-rewriter.c > colo_filter_rewriter_pkt_info(const char *func, const char *src, const char *dst, uint32_t seq, uint32_t ack, uint32_t flag) "%s: src/dst: %s/%s p: seq/ack=%u/%u flags=0x%x" > colo_filter_rewriter_conn_offset(uint32_t offset) ": offset=%u" > + > +# vhost-vdpa.c > +vhost_vdpa_set_address_space_id(void *v, unsigned vq_group, unsigned asid_num) "vhost_vdpa: %p vq_group: %u asid: %u" > diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c > index 41714d1..84876b0 100644 > --- a/net/vhost-vdpa.c > +++ b/net/vhost-vdpa.c > @@ -30,6 +30,7 @@ > #include "migration/misc.h" > #include "hw/virtio/vhost.h" > #include "hw/virtio/vhost-vdpa.h" > +#include "trace.h" > > /* Todo:need to add the multiqueue support here */ > typedef struct VhostVDPAState { > @@ -365,6 +366,8 @@ static int vhost_vdpa_set_address_space_id(struct vhost_vdpa *v, > }; > int r; > > + trace_vhost_vdpa_set_address_space_id(v, vq_group, asid_num); > + > r = ioctl(v->shared->device_fd, VHOST_VDPA_SET_GROUP_ASID, &asid); > if (unlikely(r < 0)) { > error_report("Can't set vq group %u asid %u, errno=%d (%s)", > -- > 1.8.3.1 >
On Fri, Dec 8, 2023 at 2:51 AM Si-Wei Liu <si-wei.liu@oracle.com> wrote: > > For better debuggability and observability. > > Signed-off-by: Si-Wei Liu <si-wei.liu@oracle.com> > --- > net/trace-events | 3 +++ > net/vhost-vdpa.c | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git a/net/trace-events b/net/trace-events > index 823a071..aab666a 100644 > --- a/net/trace-events > +++ b/net/trace-events > @@ -23,3 +23,6 @@ colo_compare_tcp_info(const char *pkt, uint32_t seq, uint32_t ack, int hdlen, in > # filter-rewriter.c > colo_filter_rewriter_pkt_info(const char *func, const char *src, const char *dst, uint32_t seq, uint32_t ack, uint32_t flag) "%s: src/dst: %s/%s p: seq/ack=%u/%u flags=0x%x" > colo_filter_rewriter_conn_offset(uint32_t offset) ": offset=%u" > + > +# vhost-vdpa.c > +vhost_vdpa_set_address_space_id(void *v, unsigned vq_group, unsigned asid_num) "vhost_vdpa: %p vq_group: %u asid: %u" So pointer is not user friendly, how about using the name of the netclient? Thanks > diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c > index 41714d1..84876b0 100644 > --- a/net/vhost-vdpa.c > +++ b/net/vhost-vdpa.c > @@ -30,6 +30,7 @@ > #include "migration/misc.h" > #include "hw/virtio/vhost.h" > #include "hw/virtio/vhost-vdpa.h" > +#include "trace.h" > > /* Todo:need to add the multiqueue support here */ > typedef struct VhostVDPAState { > @@ -365,6 +366,8 @@ static int vhost_vdpa_set_address_space_id(struct vhost_vdpa *v, > }; > int r; > > + trace_vhost_vdpa_set_address_space_id(v, vq_group, asid_num); > + > r = ioctl(v->shared->device_fd, VHOST_VDPA_SET_GROUP_ASID, &asid); > if (unlikely(r < 0)) { > error_report("Can't set vq group %u asid %u, errno=%d (%s)", > -- > 1.8.3.1 >
diff --git a/net/trace-events b/net/trace-events index 823a071..aab666a 100644 --- a/net/trace-events +++ b/net/trace-events @@ -23,3 +23,6 @@ colo_compare_tcp_info(const char *pkt, uint32_t seq, uint32_t ack, int hdlen, in # filter-rewriter.c colo_filter_rewriter_pkt_info(const char *func, const char *src, const char *dst, uint32_t seq, uint32_t ack, uint32_t flag) "%s: src/dst: %s/%s p: seq/ack=%u/%u flags=0x%x" colo_filter_rewriter_conn_offset(uint32_t offset) ": offset=%u" + +# vhost-vdpa.c +vhost_vdpa_set_address_space_id(void *v, unsigned vq_group, unsigned asid_num) "vhost_vdpa: %p vq_group: %u asid: %u" diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index 41714d1..84876b0 100644 --- a/net/vhost-vdpa.c +++ b/net/vhost-vdpa.c @@ -30,6 +30,7 @@ #include "migration/misc.h" #include "hw/virtio/vhost.h" #include "hw/virtio/vhost-vdpa.h" +#include "trace.h" /* Todo:need to add the multiqueue support here */ typedef struct VhostVDPAState { @@ -365,6 +366,8 @@ static int vhost_vdpa_set_address_space_id(struct vhost_vdpa *v, }; int r; + trace_vhost_vdpa_set_address_space_id(v, vq_group, asid_num); + r = ioctl(v->shared->device_fd, VHOST_VDPA_SET_GROUP_ASID, &asid); if (unlikely(r < 0)) { error_report("Can't set vq group %u asid %u, errno=%d (%s)",
For better debuggability and observability. Signed-off-by: Si-Wei Liu <si-wei.liu@oracle.com> --- net/trace-events | 3 +++ net/vhost-vdpa.c | 3 +++ 2 files changed, 6 insertions(+)