[V2,01/45] MAINTAINERS: Add reviewer for CPR

Commit Message

Steven Sistare Feb. 14, 2025, 2:13 p.m. UTC

CPR is integrated with live migration, and has the same maintainers.
But, add a CPR section to add a reviewer.

Signed-off-by: Steve Sistare <[e-mail]>
---
 MAINTAINERS | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Peter Xu Feb. 14, 2025, 2:53 p.m. UTC | #1

On Fri, Feb 14, 2025 at 06:13:43AM -0800, Steve Sistare wrote:
> CPR is integrated with live migration, and has the same maintainers.
> But, add a CPR section to add a reviewer.
> 
> Signed-off-by: Steve Sistare <[e-mail]>
> ---
>  MAINTAINERS | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3848d37..2f9a6da 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2951,6 +2951,17 @@ F: include/qemu/co-shared-resource.h
>  T: git https://gitlab.com/jsnow/qemu.git jobs
>  T: git https://gitlab.com/vsementsov/qemu.git block
>  
> +CheckPoint and Restart (CPR)
> +M: Peter Xu <[e-mail]>
> +M: Fabiano Rosas <[e-mail]>
> +R: Steve Sistare <[e-mail]>
> +S: Supported
> +F: hw/vfio/cpr*
> +F: include/migration/cpr.h
> +F: migration/cpr*
> +F: tests/qtest/migration/cpr*
> +F: docs/devel/migration/CPR.rst

All above files are covered by either migration or vfio.

If the plan is to have CPR being part of existing subsystems, IMHO we could
drop the M: entries here but keep R: only.  Or, make one M: entry for
yourself.

With that, IIUC anyone using get_maintainers.pl will always get the right
people to copy: it goes to VFIO if it's under the 1st entry (hw/vfio/cpr*),
or it goes to migration if it's the rest four entries.  Meanwhile, if any
of above is touched you'll get copied too.

> +
>  Compute Express Link
>  M: Jonathan Cameron <[e-mail]>
>  R: Fan Ni <[e-mail]>
> -- 
> 1.8.3.1
>

Steven Sistare Feb. 14, 2025, 8:14 p.m. UTC | #2

On 2/14/2025 9:53 AM, Peter Xu wrote:
> On Fri, Feb 14, 2025 at 06:13:43AM -0800, Steve Sistare wrote:
>> CPR is integrated with live migration, and has the same maintainers.
>> But, add a CPR section to add a reviewer.
>>
>> Signed-off-by: Steve Sistare <[e-mail]>
>> ---
>>   MAINTAINERS | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 3848d37..2f9a6da 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -2951,6 +2951,17 @@ F: include/qemu/co-shared-resource.h
>>   T: git https://gitlab.com/jsnow/qemu.git jobs
>>   T: git https://gitlab.com/vsementsov/qemu.git block
>>   
>> +CheckPoint and Restart (CPR)
>> +M: Peter Xu <[e-mail]>
>> +M: Fabiano Rosas <[e-mail]>
>> +R: Steve Sistare <[e-mail]>
>> +S: Supported
>> +F: hw/vfio/cpr*
>> +F: include/migration/cpr.h
>> +F: migration/cpr*
>> +F: tests/qtest/migration/cpr*
>> +F: docs/devel/migration/CPR.rst
> 
> All above files are covered by either migration or vfio.
> 
> If the plan is to have CPR being part of existing subsystems, IMHO we could
> drop the M: entries here but keep R: only.  Or, make one M: entry for
> yourself.
> 
> With that, IIUC anyone using get_maintainers.pl will always get the right
> people to copy: it goes to VFIO if it's under the 1st entry (hw/vfio/cpr*),
> or it goes to migration if it's the rest four entries.  Meanwhile, if any
> of above is touched you'll get copied too.

OK, I'll remove the M entries - steve

>> +
>>   Compute Express Link
>>   M: Jonathan Cameron <[e-mail]>
>>   R: Fan Ni <[e-mail]>
>> -- 
>> 1.8.3.1
>>
>

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 3848d37..2f9a6da 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2951,6 +2951,17 @@  F: include/qemu/co-shared-resource.h
 T: git https://gitlab.com/jsnow/qemu.git jobs
 T: git https://gitlab.com/vsementsov/qemu.git block
 
+CheckPoint and Restart (CPR)
+M: Peter Xu <[e-mail]>
+M: Fabiano Rosas <[e-mail]>
+R: Steve Sistare <[e-mail]>
+S: Supported
+F: hw/vfio/cpr*
+F: include/migration/cpr.h
+F: migration/cpr*
+F: tests/qtest/migration/cpr*
+F: docs/devel/migration/CPR.rst
+
 Compute Express Link
 M: Jonathan Cameron <[e-mail]>
 R: Fan Ni <[e-mail]>