[RFC,18/78] ui/win32-kbd-hook.c: add fallthrough pseudo-keyword

Commit Message

Manos Pitsidianakis Oct. 13, 2023, 7:47 a.m. UTC

In preparation of raising -Wimplicit-fallthrough to 5, replace all
fall-through comments with the fallthrough attribute pseudo-keyword.

Signed-off-by: Emmanouil Pitsidianakis <[e-mail]>
---
 ui/win32-kbd-hook.c | 7 -------
 1 file changed, 7 deletions(-)

Patch

diff --git a/ui/win32-kbd-hook.c b/ui/win32-kbd-hook.c
index 1ac237db9e..3c5c3fc597 100644
--- a/ui/win32-kbd-hook.c
+++ b/ui/win32-kbd-hook.c
@@ -18,59 +18,52 @@  static DWORD win32_grab;
 static LRESULT CALLBACK keyboard_hook_cb(int code, WPARAM wparam, LPARAM lparam)
 {
     if  (win32_window && code == HC_ACTION && win32_window == GetFocus()) {
         KBDLLHOOKSTRUCT *hooked = (KBDLLHOOKSTRUCT *)lparam;
 
         if (wparam != WM_KEYUP) {
             DWORD dwmsg = (hooked->flags << 24) |
                           ((hooked->scanCode & 0xff) << 16) | 1;
 
             switch (hooked->vkCode) {
             case VK_CAPITAL:
-                /* fall through */
             case VK_SCROLL:
-                /* fall through */
             case VK_NUMLOCK:
-                /* fall through */
             case VK_LSHIFT:
-                /* fall through */
             case VK_RSHIFT:
-                /* fall through */
             case VK_RCONTROL:
-                /* fall through */
             case VK_LMENU:
-                /* fall through */
             case VK_RMENU:
                 break;
 
             case VK_LCONTROL:
                 /*
                  * When pressing AltGr, an extra VK_LCONTROL with a special
                  * scancode with bit 9 set is sent. Let's ignore the extra
                  * VK_LCONTROL, as that will make AltGr misbehave.
                  */
                 if (hooked->scanCode & 0x200) {
                     return 1;
                 }
                 break;
 
             default:
                 if (win32_grab) {
                     SendMessage(win32_window, wparam, hooked->vkCode, dwmsg);
                     return 1;
                 }
                 break;
             }
 
         } else {
             switch (hooked->vkCode) {
             case VK_LCONTROL:
                 if (hooked->scanCode & 0x200) {
                     return 1;
                 }
                 break;
             }
         }
     }
 
     return CallNextHookEx(NULL, code, wparam, lparam);
 }