From patchwork Mon Jun 27 21:53:04 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pranith Kumar X-Patchwork-Id: 9201469 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 20C4C6075F for ; Mon, 27 Jun 2016 21:53:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0F06228597 for ; Mon, 27 Jun 2016 21:53:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 02328285C5; Mon, 27 Jun 2016 21:53:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7CEC128597 for ; Mon, 27 Jun 2016 21:53:27 +0000 (UTC) Received: from localhost ([::1]:33068 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHeT8-0005ME-Ha for patchwork-qemu-devel@patchwork.kernel.org; Mon, 27 Jun 2016 17:53:26 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHeSt-0005LB-2K for qemu-devel@nongnu.org; Mon, 27 Jun 2016 17:53:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bHeSo-0005Yv-QG for qemu-devel@nongnu.org; Mon, 27 Jun 2016 17:53:10 -0400 Received: from mail-qk0-x243.google.com ([2607:f8b0:400d:c09::243]:35353) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHeSo-0005Yp-M5 for qemu-devel@nongnu.org; Mon, 27 Jun 2016 17:53:06 -0400 Received: by mail-qk0-x243.google.com with SMTP id b136so32958136qkg.2 for ; Mon, 27 Jun 2016 14:53:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=vf2knOW+HubmHAtGL+uB45jDCoDHSV9ltN2LFLyIjeQ=; b=LIYJzO1alLo2T4OF78zl3DydX88Yh4iNO4M9mBrMmYIPPzBLZLirZjzBVN+O+rSH4d 8tvAVhaoQKt1jEZymmeOfVWUsMTf3i7GLPCsdaoRqJjI+kWi4nmHTf8qMa7V2UQvZ6fE lYXsph/TO35QW7OBLa/BgxRn90N5V9/NM+v1UtoLBc+hD4RvHCfh+RjCE+moDKyPl0So tlyeRnwzM1qyJQEW8TN/yiq9sAkyPWgSjHX3LvUrwN1Mf2EcWvQhY3TRhLUv6h3H8K1v 8rczzDR1jSb9p7tpDmKMtVBLrrckkQfi6uF+/By4afgKbAad+cKf1vLb3tuNFId1/M3Q lajg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=vf2knOW+HubmHAtGL+uB45jDCoDHSV9ltN2LFLyIjeQ=; b=TKAC0jncNdiOLe1kkoWuuopl2FPCknZQWwhwKXxN30lJ0WGECIuABpQC0b47bCZVSx 6r0mhQz8aS+6tQyeCbtjnZV3zH8o66nNsLkh0vtBeORo6xPuDRUyM3I5pjR2kx8eUbNy VHhKMXxNjUNFSUuR3LhbqjzvFI0yvNy/gaYOtoIYnXEle+oo4iQQAdQXroOciuRK/2AV ouEj2rX8aMcmn5KiCRHcDHs90ErVP45AQj+rkj7j0UkVI6R21efgnUvdz+DLqiyoGTC4 bYYD/K3O6q8PHWKLxJfK5WmPHqvGYtMDdiXQkNcdJvuR7Dhdchuh47XzaUNm4xYlXcM8 NOlQ== X-Gm-Message-State: ALyK8tKM/QQzOCHCWmbY4Hb+jMVSh7Cw+Wb/o9woNVNtqXrgwZKMR/6QXrtBKS3jAnw88A== X-Received: by 10.129.76.208 with SMTP id z199mr12813775ywa.32.1467064386081; Mon, 27 Jun 2016 14:53:06 -0700 (PDT) Received: from evgadesktop.attlocal.net (108-232-152-155.lightspeed.tukrga.sbcglobal.net. [108.232.152.155]) by smtp.gmail.com with ESMTPSA id b190sm2383104ywa.7.2016.06.27.14.53.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 27 Jun 2016 14:53:05 -0700 (PDT) From: Pranith Kumar To: Peter Maydell , Andrew Jeffery , qemu-devel@nongnu.org (open list:All patches CC here) Date: Mon, 27 Jun 2016 17:53:04 -0400 Message-Id: <20160627215304.821-1-bobby.prani@gmail.com> X-Mailer: git-send-email 2.9.0 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c09::243 Subject: [Qemu-devel] [PATCH] misc/aspeed_scu: Fix build error caused by missing header X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Tracing configurations error out currently as follows: /home/travis/build/pranith/qemu/hw/misc/aspeed_scu.c: In function ‘aspeed_scu_read’: /home/travis/build/pranith/qemu/hw/misc/aspeed_scu.c:130:9: error: implicit declaration of function ‘qemu_log_mask’ [-Werror=implicit-function-declaration] /home/travis/build/pranith/qemu/hw/misc/aspeed_scu.c:130:9: error: nested extern declaration of ‘qemu_log_mask’ [-Werror=nested-externs] /home/travis/build/pranith/qemu/hw/misc/aspeed_scu.c:130:23: error: ‘LOG_GUEST_ERROR’ undeclared (first use in this function) /home/travis/build/pranith/qemu/hw/misc/aspeed_scu.c:130:23: note: each undeclared identifier is reported only once for each function it appears in /home/travis/build/pranith/qemu/hw/misc/aspeed_scu.c: In function ‘aspeed_scu_write’: /home/travis/build/pranith/qemu/hw/misc/aspeed_scu.c:154:23: error: ‘LOG_GUEST_ERROR’ undeclared (first use in this function) This is caused by a missing header file. Fix it. Signed-off-by: Pranith Kumar Reviewed-by: Andrew Jeffery --- hw/misc/aspeed_scu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/misc/aspeed_scu.c b/hw/misc/aspeed_scu.c index 4f9df58..23f5175 100644 --- a/hw/misc/aspeed_scu.c +++ b/hw/misc/aspeed_scu.c @@ -15,6 +15,7 @@ #include "qapi/error.h" #include "qapi/visitor.h" #include "qemu/bitops.h" +#include "qemu/log.h" #include "trace.h" #define TO_REG(offset) ((offset) >> 2)