From patchwork Tue Aug 9 16:07:04 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?UmFkaW0gS3LEjW3DocWZ?= X-Patchwork-Id: 9271955 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4E04B60754 for ; Tue, 9 Aug 2016 17:25:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3ECE025227 for ; Tue, 9 Aug 2016 17:25:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3293E28384; Tue, 9 Aug 2016 17:25:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=2.0 tests=BAYES_00,HK_RANDOM_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B620D25227 for ; Tue, 9 Aug 2016 17:25:06 +0000 (UTC) Received: from localhost ([::1]:36940 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXAm1-0007Ak-En for patchwork-qemu-devel@patchwork.kernel.org; Tue, 09 Aug 2016 13:25:05 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48050) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bX9Yf-0001S8-9H for qemu-devel@nongnu.org; Tue, 09 Aug 2016 12:07:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bX9Yb-0006M6-0j for qemu-devel@nongnu.org; Tue, 09 Aug 2016 12:07:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58440) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bX9Ya-0006M0-OR for qemu-devel@nongnu.org; Tue, 09 Aug 2016 12:07:08 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 48CA93B71E; Tue, 9 Aug 2016 16:07:08 +0000 (UTC) Received: from potion (dhcp-1-206.brq.redhat.com [10.34.1.206]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with SMTP id u79G74wu027191; Tue, 9 Aug 2016 12:07:05 -0400 Received: by potion (sSMTP sendmail emulation); Tue, 09 Aug 2016 18:07:04 +0200 Date: Tue, 9 Aug 2016 18:07:04 +0200 From: Radim =?utf-8?B?S3LEjW3DocWZ?= To: no-reply@ec2-52-6-146-230.compute-1.amazonaws.com Message-ID: <20160809160703.GA10637@potion> References: <20160809150333.9991-1-rkrcmar@redhat.com> <20160809153149.131721.2006@ex-std-node742.prod.rhcloud.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160809153149.131721.2006@ex-std-node742.prod.rhcloud.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 09 Aug 2016 16:07:08 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] checkpatch: allow tabs in linux-headers X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: famz@redhat.com, ehabkost@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, peterx@redhat.com, jan.kiszka@web.de, pbonzini@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP 2016-08-09 08:31-0700, no-reply@ec2-52-6-146-230.compute-1.amazonaws.com: > Hi, > > Your series seems to have some coding style problems. See output below for > more information: > > Message-id: 20160809150333.9991-1-rkrcmar@redhat.com > Type: series > Subject: [Qemu-devel] [PATCH for-2.7 0/2] intel-iommu: restrict EIM to quirkless KVM > > === TEST SCRIPT BEGIN === > #!/bin/bash > > BASE=base > n=1 > total=$(git log --oneline $BASE.. | wc -l) > failed=0 > > commits="$(git log --format=%H --reverse $BASE..)" > for c in $commits; do > echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..." > if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then > failed=1 > echo > fi > n=$((n+1)) > done > > exit $failed > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > Switched to a new branch 'test' > e018fb0 intel-iommu: restrict EIM to quirkless KVM > 5ef6f2f linux-headers: update to v4.8-rc1 > > === OUTPUT BEGIN === > Checking PATCH 1/2: linux-headers: update to v4.8-rc1... > ERROR: code indent should never use tabs > #32: FILE: linux-headers/linux/kvm.h:885: > +^Iunion {$ > > ERROR: code indent should never use tabs > #33: FILE: linux-headers/linux/kvm.h:886: > +^I^I__u32 pad;$ > > ERROR: code indent should never use tabs > #34: FILE: linux-headers/linux/kvm.h:887: > +^I^I__u32 devid;$ > > ERROR: code indent should never use tabs > #35: FILE: linux-headers/linux/kvm.h:888: > +^I};$ > > ERROR: code indent should never use tabs > #43: FILE: linux-headers/linux/kvm.h:1034: > +#define KVM_MSI_VALID_DEVID^I(1U << 0)$ > > ERROR: code indent should never use tabs > #50: FILE: linux-headers/linux/kvm.h:1040: > +^I__u32 devid;$ > > ERROR: code indent should never use tabs > #51: FILE: linux-headers/linux/kvm.h:1041: > +^I__u8 pad[12];$ > > ERROR: code indent should never use tabs > #59: FILE: linux-headers/linux/kvm.h:1086: > +^IKVM_DEV_TYPE_ARM_VGIC_ITS,$ > > ERROR: code indent should never use tabs > #60: FILE: linux-headers/linux/kvm.h:1087: > +#define KVM_DEV_TYPE_ARM_VGIC_ITS^IKVM_DEV_TYPE_ARM_VGIC_ITS$ > > total: 9 errors, 0 warnings, 51 lines checked > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. These indentation errors are false positives. ---8<--- Make scripts/checkpatch.pl accept tabs in linux-headers/, instead of changing scripts/update-linux-headers.sh to expand tabs when importing. Signed-off-by: Radim Krčmář diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 929708721299..38232d4b25c3 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1355,7 +1355,7 @@ sub process { next if ($realfile !~ /\.(h|c|cpp|pl)$/); # in QEMU, no tabs are allowed - if ($rawline =~ /^\+.*\t/) { + if ($rawline =~ /^\+.*\t/ && $realfile !~ /^linux-headers\//) { my $herevet = "$here\n" . cat_vet($rawline) . "\n"; ERROR("code indent should never use tabs\n" . $herevet); $rpt_cleaners = 1;