From patchwork Tue Sep 20 12:31:44 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Dovgalyuk X-Patchwork-Id: 9341587 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DBEBF6077A for ; Tue, 20 Sep 2016 12:32:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CB56428D1C for ; Tue, 20 Sep 2016 12:32:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BD70129605; Tue, 20 Sep 2016 12:32:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id AC51B28D1C for ; Tue, 20 Sep 2016 12:32:33 +0000 (UTC) Received: from localhost ([::1]:34825 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmKDw-0004fQ-Sd for patchwork-qemu-devel@patchwork.kernel.org; Tue, 20 Sep 2016 08:32:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44712) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmKDK-0004cT-Eu for qemu-devel@nongnu.org; Tue, 20 Sep 2016 08:31:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmKDF-0000mB-Mm for qemu-devel@nongnu.org; Tue, 20 Sep 2016 08:31:53 -0400 Received: from mail.ispras.ru ([83.149.199.45]:57816) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmKDF-0000hl-Ef for qemu-devel@nongnu.org; Tue, 20 Sep 2016 08:31:49 -0400 Received: from PASHA-ISP.def.inno (unknown [85.142.117.224]) by mail.ispras.ru (Postfix) with ESMTPSA id D7995540068; Tue, 20 Sep 2016 15:31:41 +0300 (MSK) To: qemu-devel@nongnu.org From: Pavel Dovgalyuk Date: Tue, 20 Sep 2016 15:31:44 +0300 Message-ID: <20160920123144.5400.52989.stgit@PASHA-ISP.def.inno> In-Reply-To: <20160920123126.5400.29283.stgit@PASHA-ISP.def.inno> References: <20160920123126.5400.29283.stgit@PASHA-ISP.def.inno> User-Agent: StGit/0.16 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 83.149.199.45 Subject: [Qemu-devel] [PATCH v3 3/8] block: don't make snapshots for filters X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, jasowang@redhat.com, pbonzini@redhat.com, mst@redhat.com, quintela@redhat.com Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP This patch disables snapshotting for block driver filters. It is needed, because snapshots should be created in underlying disk images, not in filters itself. Signed-off-by: Pavel Dovgalyuk --- block/snapshot.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/snapshot.c b/block/snapshot.c index bf5c2ca..8998b8b 100644 --- a/block/snapshot.c +++ b/block/snapshot.c @@ -184,6 +184,9 @@ int bdrv_snapshot_goto(BlockDriverState *bs, if (!drv) { return -ENOMEDIUM; } + if (drv->is_filter) { + return 0; + } if (drv->bdrv_snapshot_goto) { return drv->bdrv_snapshot_goto(bs, snapshot_id); }