From patchwork Mon Nov 7 22:07:41 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Samuel Thibault X-Patchwork-Id: 9416141 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3A1AF6022E for ; Mon, 7 Nov 2016 22:08:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2A88528E47 for ; Mon, 7 Nov 2016 22:08:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1F1B028E49; Mon, 7 Nov 2016 22:08:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=2.0 tests=BAYES_00,FAKE_REPLY_C, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B70B528E47 for ; Mon, 7 Nov 2016 22:08:08 +0000 (UTC) Received: from localhost ([::1]:56880 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3s5H-00048W-HN for patchwork-qemu-devel@patchwork.kernel.org; Mon, 07 Nov 2016 17:08:07 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42327) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3s4v-00048K-QL for qemu-devel@nongnu.org; Mon, 07 Nov 2016 17:07:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c3s4u-0001Zu-Vn for qemu-devel@nongnu.org; Mon, 07 Nov 2016 17:07:45 -0500 Received: from hera.aquilenet.fr ([2a01:474::1]:58715) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3s4u-0001Zb-On for qemu-devel@nongnu.org; Mon, 07 Nov 2016 17:07:44 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 224A9A405; Mon, 7 Nov 2016 23:07:43 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TFjEX2Hz0uO0; Mon, 7 Nov 2016 23:07:41 +0100 (CET) Received: from var.youpi.perso.aquilenet.fr (unknown [IPv6:2a01:cb19:181:c200:3602:86ff:fe2c:6a19]) by hera.aquilenet.fr (Postfix) with ESMTPSA id D96A0794A; Mon, 7 Nov 2016 23:07:41 +0100 (CET) Received: from samy by var.youpi.perso.aquilenet.fr with local (Exim 4.87) (envelope-from ) id 1c3s4r-0001SN-9N; Mon, 07 Nov 2016 23:07:41 +0100 Date: Mon, 7 Nov 2016 23:07:41 +0100 From: Samuel Thibault To: Peter Maydell , Cornelia Huck Message-ID: <20161107220741.GL2367@var.home> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20161107172656.1b2c59bb.cornelia.huck@de.ibm.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a01:474::1 Subject: Re: [Qemu-devel] [PATCH] Fix legacy ncurses detection. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Suchanek , QEMU Developers Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Hello, On 7 November 2016 at 13:38, Michal Suchanek wrote: > - curses_inc_list="$($pkg_config --cflags ncursesw 2>/dev/null):" > + curses_inc_list="$($pkg_config --cflags ncursesw 2>/dev/null)-I/usr/include/ncursesw:" Cornelia Huck, on Mon 07 Nov 2016 17:26:56 +0100, wrote: > + if [ "$curses_inc_list" == ":" ]; then > + # some systems don't provide a proper .pc file for ncursesw > + curses_inc_list="-I/usr/include/ncursesw:" > + fi Could you rather try the attached patch? Samuel diff --git a/configure b/configure index fd6f898..e200aa8 100755 --- a/configure +++ b/configure @@ -2926,7 +2926,7 @@ if test "$curses" != "no" ; then curses_inc_list="$($pkg_config --cflags ncurses 2>/dev/null):" curses_lib_list="$($pkg_config --libs ncurses 2>/dev/null):-lpdcurses" else - curses_inc_list="$($pkg_config --cflags ncursesw 2>/dev/null):" + curses_inc_list="$($pkg_config --cflags ncursesw 2>/dev/null):-I/usr/include/ncursesw:" curses_lib_list="$($pkg_config --libs ncursesw 2>/dev/null):-lncursesw:-lcursesw" fi curses_found=no @@ -2955,6 +2955,9 @@ EOF break fi done + if test "$curses_found" = yes ; then + break + fi done unset IFS if test "$curses_found" = "yes" ; then