From patchwork Tue Nov 22 13:34:42 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eduardo Habkost X-Patchwork-Id: 9441107 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B29E560235 for ; Tue, 22 Nov 2016 13:35:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A272728456 for ; Tue, 22 Nov 2016 13:35:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 942F628524; Tue, 22 Nov 2016 13:35:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0A27428456 for ; Tue, 22 Nov 2016 13:35:24 +0000 (UTC) Received: from localhost ([::1]:55722 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9BEJ-00052Q-7x for patchwork-qemu-devel@patchwork.kernel.org; Tue, 22 Nov 2016 08:35:23 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46414) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9BDm-0004xw-Mt for qemu-devel@nongnu.org; Tue, 22 Nov 2016 08:34:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c9BDh-0006Ff-Ql for qemu-devel@nongnu.org; Tue, 22 Nov 2016 08:34:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56460) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c9BDh-0006Ez-Kc for qemu-devel@nongnu.org; Tue, 22 Nov 2016 08:34:45 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A48BD804EE for ; Tue, 22 Nov 2016 13:34:44 +0000 (UTC) Received: from localhost (ovpn-116-207.phx2.redhat.com [10.3.116.207]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAMDYhwV007403; Tue, 22 Nov 2016 08:34:44 -0500 Date: Tue, 22 Nov 2016 11:34:42 -0200 From: Eduardo Habkost To: qemu-devel@nongnu.org, Markus Armbruster , Marcel Apfelbaum , "Michael S. Tsirkin" Message-ID: <20161122133442.GC21830@thinpad.lan.raisama.net> References: <1479777133-23567-1-git-send-email-ehabkost@redhat.com> <1479777133-23567-6-git-send-email-ehabkost@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1479777133-23567-6-git-send-email-ehabkost@redhat.com> X-Fnord: you can see the fnord User-Agent: Mutt/1.7.1 (2016-10-04) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 22 Nov 2016 13:34:44 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [RFC 05/15] tests: Add rules to non-gtester qtest test cases X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP On Mon, Nov 21, 2016 at 11:12:03PM -0200, Eduardo Habkost wrote: [...] > +define qtest-target = This breaks on old GNU Make versions. Both patchew and travis-ci reported similar errors: make: *** No rule to make target `check-simpleqtest-x86_64', needed by `check-simpleqtest'. Stop. Old make versions don't seem to like the "=" operator after "define VAR". Fixed by: diff --git a/tests/Makefile.include b/tests/Makefile.include index 7016737..2799b16 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -808,7 +808,7 @@ SIMPLETEST_OPTIONS = $(if $(V),--verbose,--quiet) # $(check-simpleqtest-$(ARCH)-y) automatically includes # $(check-simpleqtest-generic-y) -define qtest-target = +define qtest-target check-simpleqtest-$(1)-y += $$(check-simpleqtest-generic-y)