From patchwork Wed Jan 11 17:35:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laszlo Ersek X-Patchwork-Id: 9510977 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3A38C601E7 for ; Wed, 11 Jan 2017 18:13:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1976328642 for ; Wed, 11 Jan 2017 18:13:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0C72928654; Wed, 11 Jan 2017 18:13:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 11CC028642 for ; Wed, 11 Jan 2017 18:13:38 +0000 (UTC) Received: from localhost ([::1]:55924 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cRNOz-0002r5-1u for patchwork-qemu-devel@patchwork.kernel.org; Wed, 11 Jan 2017 13:13:37 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42661) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cRMoJ-0005kv-46 for qemu-devel@nongnu.org; Wed, 11 Jan 2017 12:35:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cRMoH-0007ym-Tr for qemu-devel@nongnu.org; Wed, 11 Jan 2017 12:35:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45784) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cRMoH-0007yf-Ns for qemu-devel@nongnu.org; Wed, 11 Jan 2017 12:35:41 -0500 Received: from smtp.corp.redhat.com (int-mx16.intmail.prod.int.phx2.redhat.com [10.5.11.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DE13980F6D for ; Wed, 11 Jan 2017 17:35:41 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-80.phx2.redhat.com [10.3.116.80]) by smtp.corp.redhat.com (Postfix) with ESMTP id 501382D655; Wed, 11 Jan 2017 17:35:39 +0000 (UTC) From: Laszlo Ersek To: qemu devel list Date: Wed, 11 Jan 2017 18:35:28 +0100 Message-Id: <20170111173528.30510-4-lersek@redhat.com> In-Reply-To: <20170111173528.30510-1-lersek@redhat.com> References: <20170111173528.30510-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.74 on 10.5.11.28 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 11 Jan 2017 17:35:41 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v5 wave 2 3/3] hw/isa/lpc_ich9: negotiate SMI broadcast on pc-q35-2.9+ machine types X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Igor Mammedov , Paolo Bonzini , Gerd Hoffmann , Eduardo Habkost , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Cc: "Michael S. Tsirkin" Cc: Eduardo Habkost Cc: Gerd Hoffmann Cc: Igor Mammedov Cc: Paolo Bonzini Signed-off-by: Laszlo Ersek Reviewed-by: Eduardo Habkost --- Notes: v5: - replace the v4 patch "hw/i386/pc_q35: advertise broadcast SMI if VCPU hotplug is turned off" with a simple device property and compat setting [Igor] include/hw/i386/pc.h | 5 +++++ hw/isa/lpc_ich9.c | 2 ++ 2 files changed, 7 insertions(+) diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index 230e9e70c504..fb8ca7c907f6 100644 --- a/include/hw/i386/pc.h +++ b/include/hw/i386/pc.h @@ -376,6 +376,11 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *); #define PC_COMPAT_2_8 \ HW_COMPAT_2_8 \ + {\ + .driver = "ICH9-LPC",\ + .property = "smi_broadcast",\ + .value = "off",\ + },\ #define PC_COMPAT_2_7 \ diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c index ced6f803a4f2..27fae5144744 100644 --- a/hw/isa/lpc_ich9.c +++ b/hw/isa/lpc_ich9.c @@ -776,6 +776,8 @@ static const VMStateDescription vmstate_ich9_lpc = { static Property ich9_lpc_properties[] = { DEFINE_PROP_BOOL("noreboot", ICH9LPCState, pin_strap.spkr_hi, true), + DEFINE_PROP_BIT64("smi_broadcast", ICH9LPCState, smi_host_features, + ICH9_LPC_SMI_F_BROADCAST_BIT, true), DEFINE_PROP_END_OF_LIST(), };