| Message ID | 20170116211124.29245-3-ehabkost@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Jan 16, 2017 at 07:11:22PM -0200, Eduardo Habkost wrote: > Add a note warning that static expansion may not be 100% accurate > when the CPU model is not migration-safe. This will be the case > on x86 when expansing the "host" CPU model, because there are > "host" features that can't have a migration-safe representation > (e.g. "host-cache-info"). > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> Applied to x86-next. > --- > qapi-schema.json | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/qapi-schema.json b/qapi-schema.json > index ce20f16757..33d7ef1274 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -3294,6 +3294,15 @@ > # migration-safe, but allows tooling to get an insight and work with > # model details. > # > +# Note: When a non-migration-safe CPU model is expanded in static mode, some > +# features enabled by the CPU model may be omitted, because they can't be > +# implemented by a static CPU model definition (e.g. cache info passthrough and > +# PMU passthrough in x86). If you need an accurate representation of the > +# features enabled by a non-migration-safe CPU model, use @full. If you need a > +# static representation that will keep ABI compatibility even when changing QEMU > +# version or machine-type, use @static (but keep in mind that some features may > +# be omitted). > +# > # Since: 2.8.0 > ## > { 'enum': 'CpuModelExpansionType', > -- > 2.11.0.259.g40922b1 > >
diff --git a/qapi-schema.json b/qapi-schema.json index ce20f16757..33d7ef1274 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -3294,6 +3294,15 @@ # migration-safe, but allows tooling to get an insight and work with # model details. # +# Note: When a non-migration-safe CPU model is expanded in static mode, some +# features enabled by the CPU model may be omitted, because they can't be +# implemented by a static CPU model definition (e.g. cache info passthrough and +# PMU passthrough in x86). If you need an accurate representation of the +# features enabled by a non-migration-safe CPU model, use @full. If you need a +# static representation that will keep ABI compatibility even when changing QEMU +# version or machine-type, use @static (but keep in mind that some features may +# be omitted). +# # Since: 2.8.0 ## { 'enum': 'CpuModelExpansionType',
Add a note warning that static expansion may not be 100% accurate when the CPU model is not migration-safe. This will be the case on x86 when expansing the "host" CPU model, because there are "host" features that can't have a migration-safe representation (e.g. "host-cache-info"). Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> --- qapi-schema.json | 9 +++++++++ 1 file changed, 9 insertions(+)