From patchwork Wed Jan 18 16:16:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Eric Blake X-Patchwork-Id: 9524299 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A4D9360113 for ; Wed, 18 Jan 2017 17:01:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 980DB285EF for ; Wed, 18 Jan 2017 17:01:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8C3BA285F5; Wed, 18 Jan 2017 17:01:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3919F285EF for ; Wed, 18 Jan 2017 17:01:52 +0000 (UTC) Received: from localhost ([::1]:42672 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cTtcN-0008MI-AC for patchwork-qemu-devel@patchwork.kernel.org; Wed, 18 Jan 2017 12:01:51 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42260) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cTsvA-0005RJ-4K for qemu-devel@nongnu.org; Wed, 18 Jan 2017 11:17:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cTsv8-0005vu-T5 for qemu-devel@nongnu.org; Wed, 18 Jan 2017 11:17:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52774) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cTsv8-0005vG-Nk for qemu-devel@nongnu.org; Wed, 18 Jan 2017 11:17:10 -0500 Received: from smtp.corp.redhat.com (int-mx16.intmail.prod.int.phx2.redhat.com [10.5.11.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F0FA272CC1 for ; Wed, 18 Jan 2017 16:17:10 +0000 (UTC) Received: from red.redhat.com (ovpn-117-52.rdu2.redhat.com [10.10.117.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7A43A6D9BC; Wed, 18 Jan 2017 16:17:10 +0000 (UTC) From: Eric Blake To: qemu-devel@nongnu.org Date: Wed, 18 Jan 2017 10:16:53 -0600 Message-Id: <20170118161653.19296-7-eblake@redhat.com> In-Reply-To: <20170118161653.19296-1-eblake@redhat.com> References: <20170118161653.19296-1-eblake@redhat.com> X-Scanned-By: MIMEDefang 2.74 on 10.5.11.28 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 18 Jan 2017 16:17:10 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 6/6] qapi: Promote blockdev-change-medium arguments to QAPI type X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: armbru@redhat.com Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Having a named rather than anonymous C type will make it easier to improve the testsuite in a later patch. No semantic change, to any of the existing code or to the introspection output. Signed-off-by: Eric Blake Reviewed-by: Marc-André Lureau --- v2: rebase to master --- qapi/block-core.json | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 1b3e6eb..0e31d25 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -3119,6 +3119,15 @@ # combines blockdev-open-tray, x-blockdev-remove-medium, # x-blockdev-insert-medium and blockdev-close-tray). # +# Since: 2.5 +## +{ 'command': 'blockdev-change-medium', + 'data': 'BlockdevChangeMedium' } + + +## +# @BlockdevChangeMedium: +# # @device: #optional Block device name (deprecated, use @id instead) # # @id: #optional The name or QOM path of the guest device @@ -3165,7 +3174,7 @@ # <- { "return": {} } # ## -{ 'command': 'blockdev-change-medium', +{ 'struct': 'BlockdevChangeMedium', 'data': { '*device': 'str', '*id': 'str', 'filename': 'str',