| Message ID | 20170125052703.23571-1-lma@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Lin Ma <lma@suse.com> writes: > The argument is called "typename", not "name". > > [Thanks to Markus for correcting the commit message] > > Signed-off-by: Lin Ma <lma@suse.com> > --- > qmp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/qmp.c b/qmp.c > index 0028f0b..886059e 100644 > --- a/qmp.c > +++ b/qmp.c > @@ -531,12 +531,12 @@ DevicePropertyInfoList *qmp_device_list_properties(const char *typename, > > klass = object_class_dynamic_cast(klass, TYPE_DEVICE); > if (klass == NULL) { > - error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "name", TYPE_DEVICE); > + error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "typename", TYPE_DEVICE); > return NULL; > } > > if (object_class_is_abstract(klass)) { > - error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "name", > + error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "typename", > "non-abstract device type"); > return NULL; > } Reviewed-by: Markus Armbruster <armbru@redhat.com>
Markus Armbruster <armbru@redhat.com> writes: > Lin Ma <lma@suse.com> writes: > >> The argument is called "typename", not "name". >> >> [Thanks to Markus for correcting the commit message] >> >> Signed-off-by: Lin Ma <lma@suse.com> >> --- >> qmp.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/qmp.c b/qmp.c >> index 0028f0b..886059e 100644 >> --- a/qmp.c >> +++ b/qmp.c >> @@ -531,12 +531,12 @@ DevicePropertyInfoList *qmp_device_list_properties(const char *typename, >> >> klass = object_class_dynamic_cast(klass, TYPE_DEVICE); >> if (klass == NULL) { >> - error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "name", TYPE_DEVICE); >> + error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "typename", TYPE_DEVICE); >> return NULL; >> } >> >> if (object_class_is_abstract(klass)) { >> - error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "name", >> + error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "typename", >> "non-abstract device type"); >> return NULL; >> } > > Reviewed-by: Markus Armbruster <armbru@redhat.com> Applied to my tree, thanks! http://repo.or.cz/qemu/armbru.git/shortlog/refs/heads/qapi-next
diff --git a/qmp.c b/qmp.c index 0028f0b..886059e 100644 --- a/qmp.c +++ b/qmp.c @@ -531,12 +531,12 @@ DevicePropertyInfoList *qmp_device_list_properties(const char *typename, klass = object_class_dynamic_cast(klass, TYPE_DEVICE); if (klass == NULL) { - error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "name", TYPE_DEVICE); + error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "typename", TYPE_DEVICE); return NULL; } if (object_class_is_abstract(klass)) { - error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "name", + error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "typename", "non-abstract device type"); return NULL; }
The argument is called "typename", not "name". [Thanks to Markus for correcting the commit message] Signed-off-by: Lin Ma <lma@suse.com> --- qmp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)