From patchwork Fri Feb 17 21:47:52 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Cody X-Patchwork-Id: 9580817 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 612E7600C5 for ; Fri, 17 Feb 2017 21:48:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 52B4528492 for ; Fri, 17 Feb 2017 21:48:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 46AA028793; Fri, 17 Feb 2017 21:48:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1C50E28492 for ; Fri, 17 Feb 2017 21:48:28 +0000 (UTC) Received: from localhost ([::1]:56223 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ceqOA-000231-Gz for patchwork-qemu-devel@patchwork.kernel.org; Fri, 17 Feb 2017 16:48:26 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54919) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ceqNj-00021J-Pj for qemu-devel@nongnu.org; Fri, 17 Feb 2017 16:48:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ceqNj-00049k-3D for qemu-devel@nongnu.org; Fri, 17 Feb 2017 16:47:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53218) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ceqNe-00043Z-IL; Fri, 17 Feb 2017 16:47:54 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6C02981226; Fri, 17 Feb 2017 21:47:54 +0000 (UTC) Received: from localhost (ovpn-116-19.phx2.redhat.com [10.3.116.19]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v1HLlr9S027846 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 17 Feb 2017 16:47:54 -0500 Date: Fri, 17 Feb 2017 16:47:52 -0500 From: Jeff Cody To: Eric Blake Message-ID: <20170217214752.GL19045@localhost.localdomain> References: <36a56ad1-9a1a-9542-1b54-389fddc7081e@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <36a56ad1-9a1a-9542-1b54-389fddc7081e@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 17 Feb 2017 21:47:54 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v2 6/7] iscsi: Add blockdev-add support X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP On Fri, Feb 17, 2017 at 03:40:21PM -0600, Eric Blake wrote: > On 01/25/2017 11:42 AM, Jeff Cody wrote: > > From: Kevin Wolf > > > > This adds blockdev-add support for iscsi devices. > > > > Reviewed-by: Daniel P. Berrange > > Signed-off-by: Kevin Wolf > > Signed-off-by: Jeff Cody > > --- > > block/iscsi.c | 14 ++++++---- > > qapi/block-core.json | 74 ++++++++++++++++++++++++++++++++++++++++++++++++---- > > 2 files changed, 78 insertions(+), 10 deletions(-) > > > +++ b/qapi/block-core.json > > @@ -2116,10 +2116,10 @@ > > { 'enum': 'BlockdevDriver', > > 'data': [ 'archipelago', 'blkdebug', 'blkverify', 'bochs', 'cloop', > > 'dmg', 'file', 'ftp', 'ftps', 'gluster', 'host_cdrom', > > - 'host_device', 'http', 'https', 'luks', 'nbd', 'nfs', 'null-aio', > > - 'null-co', 'parallels', 'qcow', 'qcow2', 'qed', 'quorum', 'raw', > > - 'replication', 'ssh', 'vdi', 'vhdx', 'vmdk', 'vpc', > > - 'vvfat' ] } > > + 'host_device', 'http', 'https', 'iscsi', 'luks', 'nbd', 'nfs', > > + 'null-aio', 'null-co', 'parallels', 'qcow', 'qcow2', 'qed', > > + 'quorum', 'raw', 'replication', 'ssh', 'vdi', 'vhdx', 'vmdk', > > + 'vpc', 'vvfat' ] } > > Are we missing a since 2.9 documentation designation here? > Yes, thanks for catching that. I've applied it to my branch already, but I will go ahead and fix this and rebase with the following squashed into the patch: diff --git a/qapi/block-core.json b/qapi/block-core.json index f00fc9d..5f82d35 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -2110,6 +2110,7 @@ # @nfs: Since 2.8 # @replication: Since 2.8 # @ssh: Since 2.8 +# @iscsi: Since 2.9 # # Since: 2.0 ##