| Message ID | 20170220164509.27868-1-v.maffione@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Vincenzo Maffione <v.maffione@gmail.com> writes: > In the vhost-user example, a chardev with id chr0 is referenced by the > vhost-user net backend, but the id is not specified in the chardev option. > > Signed-off-by: Vincenzo Maffione <v.maffione@gmail.com> > --- > qemu-options.hx | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qemu-options.hx b/qemu-options.hx > index 5633d3914f..ed22fc479a 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -2127,7 +2127,7 @@ Example: > @example > qemu -m 512 -object memory-backend-file,id=mem,size=512M,mem-path=/hugetlbfs,share=on \ > -numa node,memdev=mem \ > - -chardev socket,path=/path/to/socket \ > + -chardev socket,id=chr0,path=/path/to/socket \ > -netdev type=vhost-user,id=net0,chardev=chr0 \ > -device virtio-net-pci,netdev=net0 > @end example Reviewed-by: Markus Armbruster <armbru@redhat.com> Aside: a test that extracts its test cases out of qemu-options.hx and verifies they at least don't make startup fail would be nice. Bit-sized task only if you have a really big jaw, I'm afraid.
Applied to -trivial, thanks! /mjt
diff --git a/qemu-options.hx b/qemu-options.hx index 5633d3914f..ed22fc479a 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2127,7 +2127,7 @@ Example: @example qemu -m 512 -object memory-backend-file,id=mem,size=512M,mem-path=/hugetlbfs,share=on \ -numa node,memdev=mem \ - -chardev socket,path=/path/to/socket \ + -chardev socket,id=chr0,path=/path/to/socket \ -netdev type=vhost-user,id=net0,chardev=chr0 \ -device virtio-net-pci,netdev=net0 @end example
In the vhost-user example, a chardev with id chr0 is referenced by the vhost-user net backend, but the id is not specified in the chardev option. Signed-off-by: Vincenzo Maffione <v.maffione@gmail.com> --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)