From patchwork Thu Mar 2 19:53:29 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 9601471 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 137EB600CB for ; Thu, 2 Mar 2017 19:55:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0003A285E5 for ; Thu, 2 Mar 2017 19:55:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E6FB7285E8; Thu, 2 Mar 2017 19:55:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 747BA285E5 for ; Thu, 2 Mar 2017 19:55:52 +0000 (UTC) Received: from localhost ([::1]:54274 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjWpL-0001Eb-FK for patchwork-qemu-devel@patchwork.kernel.org; Thu, 02 Mar 2017 14:55:51 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59618) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjWnG-0007xD-O1 for qemu-devel@nongnu.org; Thu, 02 Mar 2017 14:53:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cjWnF-0002T2-F9 for qemu-devel@nongnu.org; Thu, 02 Mar 2017 14:53:42 -0500 Received: from mail-wm0-x235.google.com ([2a00:1450:400c:c09::235]:37536) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cjWnF-0002Sh-8O for qemu-devel@nongnu.org; Thu, 02 Mar 2017 14:53:41 -0500 Received: by mail-wm0-x235.google.com with SMTP id n11so132165wma.0 for ; Thu, 02 Mar 2017 11:53:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HBbLqHvQC5yHtS/+IDR28AnQ1+6F5Z4yhDyaU3w2t3M=; b=SjXqhkz+mmRskwCPE3wnOMquY1D4ihtgbfvIgGbubZMeaXciIanIcnyM1lFJtEtRPR 3Als6nfYLASC/9yxF4EVJMbTyghZ9R4htoJ9OzVosYb21b2Ej0crjJ6cpCZrp/cMYIjv 1Gb7E9Q844qiFefI2HYigUKcyIIrDTND/9/m0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HBbLqHvQC5yHtS/+IDR28AnQ1+6F5Z4yhDyaU3w2t3M=; b=OoP5yvYObJBoqoaQcxCHI5y+KgVFZFUw48lkCBKHI6jksJKWw0JeiXmTugSh0Cemwz YWYfEI4b8mx+LVWIbMZS6Uh1tGXkvlH6SeHr657iX6trPsNyx20K8VjNEch8lPC6lZhZ 6NjIKK/rcoW8dHpKzCUHFhXA5wyk0xLg8XC/iT6VKXAjhSHom6tb3jOhq8iPgGyj2z/A 3HK8vMQgyNRiG9FHN81MJ8oMzFhAijIUiAzBrE1Bs32iKP/XI0UE05/5YUKQMQIfpfJq IXC3kJfqsknTlkZeRGEWCm5Bth+zU6QFZkIBEBdvKhXD+7cAmRFh8XvJU2OnsceqIgb/ aqQg== X-Gm-Message-State: AMke39mJXQDiNZ94MjsQuGJbLOwie9NBaoZLnTICMuxuAHvRmIGYfBuE7tNadIedfg+11GQf X-Received: by 10.28.130.207 with SMTP id e198mr27459wmd.4.1488484420100; Thu, 02 Mar 2017 11:53:40 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id o143sm2097wmd.3.2017.03.02.11.53.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Mar 2017 11:53:37 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 4BAD63E02E1; Thu, 2 Mar 2017 19:53:37 +0000 (GMT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: peter.maydell@linaro.org, rth@twiddle.net, pbonzini@redhat.com Date: Thu, 2 Mar 2017 19:53:29 +0000 Message-Id: <20170302195337.31558-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170302195337.31558-1-alex.bennee@linaro.org> References: <20170302195337.31558-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::235 Subject: [Qemu-devel] [PATCH v2 03/11] cpus.c: add additional error_report when !TARGET_SUPPORT_MTTCG X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mttcg@listserver.greensocs.com, nikunj@linux.vnet.ibm.com, Peter Crosthwaite , a.rigo@virtualopensystems.com, qemu-devel@nongnu.org, cota@braap.org, bobby.prani@gmail.com, =?UTF-8?q?Alex=20Benn=C3=A9e?= , fred.konrad@greensocs.com Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP While we may fail the memory ordering check later that can be confusing. So in cases where TARGET_SUPPORT_MTTCG has yet to be defined we should say so specifically. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- cpus.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/cpus.c b/cpus.c index e9aab9f70f..2459f564ea 100644 --- a/cpus.c +++ b/cpus.c @@ -206,6 +206,10 @@ void qemu_tcg_configure(QemuOpts *opts, Error **errp) } else if (use_icount) { error_setg(errp, "No MTTCG when icount is enabled"); } else { +#ifndef TARGET_SUPPORT_MTTCG + error_report("Guest not yet converted to MTTCG - " + "you may get unexpected results"); +#endif if (!check_tcg_memory_orders_compatible()) { error_report("Guest expects a stronger memory ordering " "than the host provides");