| Message ID | 20170303131113.25898-2-pbonzini@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Mar 03, 2017 at 02:11:09PM +0100, Paolo Bonzini wrote: > If the first timer is exactly at the current value of the clock, the > deadline is met and the timer should fire. This fixes itself without icount, > but with icount execution of instructions will stop exactly at the deadline. > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> > --- > util/qemu-timer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/util/qemu-timer.c b/util/qemu-timer.c > index 6cf70b9..2f20151 100644 > --- a/util/qemu-timer.c > +++ b/util/qemu-timer.c > @@ -199,7 +199,7 @@ bool timerlist_expired(QEMUTimerList *timer_list) > expire_time = timer_list->active_timers->expire_time; > qemu_mutex_unlock(&timer_list->active_timers_lock); > > - return expire_time < qemu_clock_get_ns(timer_list->clock->type); > + return expire_time <= qemu_clock_get_ns(timer_list->clock->type); > } > > bool qemu_clock_expired(QEMUClockType type) > -- > 2.9.3 > > >
Paolo Bonzini <pbonzini@redhat.com> writes: > If the first timer is exactly at the current value of the clock, the > deadline is met and the timer should fire. This fixes itself without icount, > but with icount execution of instructions will stop exactly at the deadline. > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Reviewed-by: Alex Bennée <alex.bennee@linaro.org> > --- > util/qemu-timer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/util/qemu-timer.c b/util/qemu-timer.c > index 6cf70b9..2f20151 100644 > --- a/util/qemu-timer.c > +++ b/util/qemu-timer.c > @@ -199,7 +199,7 @@ bool timerlist_expired(QEMUTimerList *timer_list) > expire_time = timer_list->active_timers->expire_time; > qemu_mutex_unlock(&timer_list->active_timers_lock); > > - return expire_time < qemu_clock_get_ns(timer_list->clock->type); > + return expire_time <= qemu_clock_get_ns(timer_list->clock->type); > } > > bool qemu_clock_expired(QEMUClockType type) -- Alex Bennée
diff --git a/util/qemu-timer.c b/util/qemu-timer.c index 6cf70b9..2f20151 100644 --- a/util/qemu-timer.c +++ b/util/qemu-timer.c @@ -199,7 +199,7 @@ bool timerlist_expired(QEMUTimerList *timer_list) expire_time = timer_list->active_timers->expire_time; qemu_mutex_unlock(&timer_list->active_timers_lock); - return expire_time < qemu_clock_get_ns(timer_list->clock->type); + return expire_time <= qemu_clock_get_ns(timer_list->clock->type); } bool qemu_clock_expired(QEMUClockType type)
If the first timer is exactly at the current value of the clock, the deadline is met and the timer should fire. This fixes itself without icount, but with icount execution of instructions will stop exactly at the deadline. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- util/qemu-timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)