From patchwork Sat Mar 4 18:55:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 9604219 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A6CB660414 for ; Sat, 4 Mar 2017 18:56:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9F1EE2839C for ; Sat, 4 Mar 2017 18:56:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 937212844C; Sat, 4 Mar 2017 18:56:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 42C812839C for ; Sat, 4 Mar 2017 18:56:38 +0000 (UTC) Received: from localhost ([::1]:36283 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckEr7-0005sa-As for patchwork-qemu-devel@patchwork.kernel.org; Sat, 04 Mar 2017 13:56:37 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57717) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckEqq-0005rI-H0 for qemu-devel@nongnu.org; Sat, 04 Mar 2017 13:56:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ckEqp-0007Sl-M7 for qemu-devel@nongnu.org; Sat, 04 Mar 2017 13:56:20 -0500 Received: from mail-qk0-x242.google.com ([2607:f8b0:400d:c09::242]:32897) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ckEqp-0007SX-Hd for qemu-devel@nongnu.org; Sat, 04 Mar 2017 13:56:19 -0500 Received: by mail-qk0-x242.google.com with SMTP id j127so16932260qke.0 for ; Sat, 04 Mar 2017 10:56:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZNny5TduYcsL1iaP55GB0BUf3QSakI7Nsdf80woC51k=; b=TgtDiaHHuguQ555UByqlFz65hz8iN4jrqaQY74qqxTN1ilsG4ZdKtS+cEVZejzrYDI 5wXT8UZcIY7Y22+3iD+X+i3AZ2LCOsgbbG4eDW3OvMDqaNiYBxI9mHKOmMf961nRfsFA uU5zfrCZumsvs8VesLtFh7xQEL3gv1Tlqqlb6Wq9sqcX6fQfh7zSSs2VcJa7YKOEY6cy WPbyOvX6Dh3orzrCA+abyKr6f2H9Gzk2DXconFoKcNCCAiXrE69G08rk97GUPZs0ey27 oxqEsB0GRFAVKRigHWPgrenzrMKm+0EshcS7ACshLnNYXW62ejo0XWhb8w0liouDwJOt nu2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ZNny5TduYcsL1iaP55GB0BUf3QSakI7Nsdf80woC51k=; b=l4ljkT9e+exCvdjzas8d6x9z1rJKG41hetJks1aj3yAFoow4SOVwq0QJ7xovHlhDU8 pCBV3OaV1GJmFCSIcugioKzclesMTtqtcPiBqcgAFQuMkQoKP3yQs77DYx1MMPBY9J4Z j+ZK5OexcZ91akVNbcFvWukkjfh8jYcX9qTuOmNigeQvS1evO5YNSH2h5AqA0JtoHaty y/y6Z+rDvpcmHmxOAO2szebiRNqNr6X05+C4FpvUtG4ylNFe3XzKIFmM8QPLvEsP8IJM eC6WvQNAjXsc5dTCHw74s2cFsqchvqEUL3veTpjtCjrlFu55GvzF8Iha0j0x/5Ft/sJR 52Aw== X-Gm-Message-State: AMke39kSgpzQGMoLadU05v2jZ1zS20YvaY26D7hOkRYHXt61h5fX6OjjRyQArm7xIVe/qQ== X-Received: by 10.233.239.140 with SMTP id d134mr7832901qkg.313.1488653778942; Sat, 04 Mar 2017 10:56:18 -0800 (PST) Received: from yoga.lan ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id o14sm10065138qtc.46.2017.03.04.10.56.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 04 Mar 2017 10:56:18 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Michael Roth , Peter Crosthwaite , Alexander Graf , Gerd Hoffmann Date: Sat, 4 Mar 2017 15:55:31 -0300 Message-Id: <20170304185533.10618-2-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170304185533.10618-1-f4bug@amsat.org> References: <20170304185533.10618-1-f4bug@amsat.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::242 Subject: [Qemu-devel] [PATCH 1/3] usb-ccid: make ccid_write_data_block() cope with null buffers X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP static code analyzer complain: hw/usb/dev-smartcard-reader.c:816:5: warning: Null pointer passed as an argument to a 'nonnull' parameter memcpy(p->abData, data, len); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Marc-André Lureau --- hw/usb/dev-smartcard-reader.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c index 757b8b3f5a..c38a4e5886 100644 --- a/hw/usb/dev-smartcard-reader.c +++ b/hw/usb/dev-smartcard-reader.c @@ -799,8 +799,14 @@ static void ccid_write_parameters(USBCCIDState *s, CCID_Header *recv) static void ccid_write_data_block(USBCCIDState *s, uint8_t slot, uint8_t seq, const uint8_t *data, uint32_t len) { - CCID_DataBlock *p = ccid_reserve_recv_buf(s, sizeof(*p) + len); + CCID_DataBlock *p; + if (len == 0) { + return; + } + g_assert(data != NULL); + + p = ccid_reserve_recv_buf(s, sizeof(*p) + len); if (p == NULL) { return; }