From patchwork Thu Mar 16 11:14:16 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinzenz 'evilissimo' Feenstra X-Patchwork-Id: 9636543 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 73068602D6 for ; Tue, 21 Mar 2017 12:30:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6387E28329 for ; Tue, 21 Mar 2017 12:30:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5841128338; Tue, 21 Mar 2017 12:30:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=2.0 tests=BAYES_00, DATE_IN_PAST_96_XX, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D53F428306 for ; Tue, 21 Mar 2017 12:30:38 +0000 (UTC) Received: from localhost ([::1]:39326 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cqIvt-0005wr-Eb for patchwork-qemu-devel@patchwork.kernel.org; Tue, 21 Mar 2017 08:30:37 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51571) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cqIvd-0005uu-Ge for qemu-devel@nongnu.org; Tue, 21 Mar 2017 08:30:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cqIva-0002nJ-B0 for qemu-devel@nongnu.org; Tue, 21 Mar 2017 08:30:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33914) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cqIva-0002n1-4t; Tue, 21 Mar 2017 08:30:18 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CAFF185547; Tue, 21 Mar 2017 12:30:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com CAFF185547 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=vfeenstr@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com CAFF185547 Received: from localhost.localdomain.com (dhcp131-51.brq.redhat.com [10.34.131.51]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2CE51A84CD; Tue, 21 Mar 2017 12:30:15 +0000 (UTC) From: Vinzenz 'evilissimo' Feenstra To: qemu-devel@nongnu.org Date: Thu, 16 Mar 2017 12:14:16 +0100 Message-Id: <20170316111416.25587-1-vfeenstr@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 21 Mar 2017 12:30:18 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] checkpatch: Supress warning in function pointer typedefs X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com, Vinzenz Feenstra Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Vinzenz Feenstra When importing dynamically functions via `GetProcAddress` in windows related code, it is quite common to make a typedef for the resulting function pointer. When the function to be imported, has a stdcall calling convention, usually the `WINAPI` macro is used. This patch adds an exception in the checkpatch.pl script to allow the calling convention specification in function pointer typedefs, to be `WINAPI`. Signed-off-by: Vinzenz Feenstra --- scripts/checkpatch.pl | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index f084542..33bf585 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1774,7 +1774,14 @@ sub process { # likely a typedef for a function. } elsif ($ctx =~ /$Type$/) { - } else { + # If this is a typedef we need to allow WINAPI as a calling + # convention. Even though there should be only one space around the + # star, we allow none or any, to suppress the following warning. + # The check for the number of spaces around the star is checked + # elsewhere. + } elsif($ctx =~ /^\s*typedef\s+$Type\(WINAPI\s*\*\s*$Ident\)/) { + + } else { ERROR("space prohibited between function name and open parenthesis '('\n" . $herecurr); } }