diff mbox

[qemu-ga] Start VSS Provider after install

Message ID 20170321120326.10011-1-sameeh@daynix.com (mailing list archive)
State New, archived
Headers show

Commit Message

Sameeh Jubran March 21, 2017, 12:03 p.m. UTC 
Signed-off-by: Sameeh Jubran <sameeh@daynix.com>
---
 qga/vss-win32/install.cpp | 1 +
 1 file changed, 1 insertion(+)

Comments

Michael Roth March 21, 2017, 4:15 p.m. UTC | #1 
Quoting Sameeh Jubran (2017-03-21 07:03:26)
> Signed-off-by: Sameeh Jubran <sameeh@daynix.com>

What happens without this patch? Fresh installs don't report the
fsfreeze interface as available?

> ---
>  qga/vss-win32/install.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/qga/vss-win32/install.cpp b/qga/vss-win32/install.cpp
> index f4160a3..7e38332 100644
> --- a/qga/vss-win32/install.cpp
> +++ b/qga/vss-win32/install.cpp
> @@ -307,6 +307,7 @@ STDAPI COMRegister(void)
>      chk(put_Value(pObj, L"User", L"SYSTEM"));
>      chk(pUsersInRole->SaveChanges(&n));
> 
> +    chk(pCatalog->StartApplication(_bstr_t(QGA_PROVIDER_LNAME)));
>  out:
>      if (unregisterOnFailure && FAILED(hr)) {
>          COMUnregister();
> -- 
> 2.9.3
>
Sameeh Jubran March 22, 2017, 10:58 a.m. UTC | #2 
On Tue, Mar 21, 2017 at 6:15 PM, Michael Roth <mdroth@linux.vnet.ibm.com>
wrote:

> Quoting Sameeh Jubran (2017-03-21 07:03:26)
> > Signed-off-by: Sameeh Jubran <sameeh@daynix.com>
>
> What happens without this patch? Fresh installs don't report the
> fsfreeze interface as available?
>
 It solves a bug (https://bugzilla.redhat.com/show_bug.cgi?id=1218937) that
was reported in bugzilla, however
 thinking about it again this patch is not needed as the service should
only be running when it is needed.

>
> > ---
> >  qga/vss-win32/install.cpp | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/qga/vss-win32/install.cpp b/qga/vss-win32/install.cpp
> > index f4160a3..7e38332 100644
> > --- a/qga/vss-win32/install.cpp
> > +++ b/qga/vss-win32/install.cpp
> > @@ -307,6 +307,7 @@ STDAPI COMRegister(void)
> >      chk(put_Value(pObj, L"User", L"SYSTEM"));
> >      chk(pUsersInRole->SaveChanges(&n));
> >
> > +    chk(pCatalog->StartApplication(_bstr_t(QGA_PROVIDER_LNAME)));
> >  out:
> >      if (unregisterOnFailure && FAILED(hr)) {
> >          COMUnregister();
> > --
> > 2.9.3
> >
>
>
diff mbox

Patch

diff --git a/qga/vss-win32/install.cpp b/qga/vss-win32/install.cpp
index f4160a3..7e38332 100644
--- a/qga/vss-win32/install.cpp
+++ b/qga/vss-win32/install.cpp
@@ -307,6 +307,7 @@  STDAPI COMRegister(void)
     chk(put_Value(pObj, L"User", L"SYSTEM"));
     chk(pUsersInRole->SaveChanges(&n));
 
+    chk(pCatalog->StartApplication(_bstr_t(QGA_PROVIDER_LNAME)));
 out:
     if (unregisterOnFailure && FAILED(hr)) {
         COMUnregister();