From patchwork Sun Mar 26 09:56:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sameeh Jubran X-Patchwork-Id: 9644985 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BFC3760327 for ; Sun, 26 Mar 2017 09:57:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9D7D4201F3 for ; Sun, 26 Mar 2017 09:57:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 80D6A205A8; Sun, 26 Mar 2017 09:57:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 40847201F3 for ; Sun, 26 Mar 2017 09:57:09 +0000 (UTC) Received: from localhost ([::1]:40222 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cs4v6-0007Oc-3Q for patchwork-qemu-devel@patchwork.kernel.org; Sun, 26 Mar 2017 05:57:08 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cs4uV-0007Mr-SR for qemu-devel@nongnu.org; Sun, 26 Mar 2017 05:56:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cs4uS-0002xn-PL for qemu-devel@nongnu.org; Sun, 26 Mar 2017 05:56:31 -0400 Received: from mail-wr0-x243.google.com ([2a00:1450:400c:c0c::243]:34417) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cs4uS-0002xb-J0 for qemu-devel@nongnu.org; Sun, 26 Mar 2017 05:56:28 -0400 Received: by mail-wr0-x243.google.com with SMTP id w43so1432092wrb.1 for ; Sun, 26 Mar 2017 02:56:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=4uvKgi0fuTRUlkxLjdUy5zWTMSa6mh0FcZGrBOybw6U=; b=DBqV0mJOoDHnDZgQUvbMdn6NqKSdPA0jKUp66CpaWHtOGKz7Qe5459kaP+6ZB7y5X9 p+8BTj4Io1kueIsEEJ7Es9/bYiXlygnOL7eDYT2t8fTd0LnEqPlRk1cHxM43dud7EVxa j0dTxHDNDSF920EwSthQExJa8HQbGNa3npzUhXBxEnuTTRkXohxufyRYM1vZFRvevuUp 2Kw8Lny4O5p4/igUCcIkzVv5zshjNpdEk67GPJp00WSDvwrm4VrQdotamRUPUNiJLnJr 0/QiSHSDoacPs/FEkoWiLGv3fnKmigy4ktta6Nw7w8RLqVjtAnJkZxLOijE4P20V2YMJ HqQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=4uvKgi0fuTRUlkxLjdUy5zWTMSa6mh0FcZGrBOybw6U=; b=sQGhefCm/J+tz96lsDx3cJuVG0CeTgNR2Kzi0r2TEkJJcMeh0C5Ot/LgW8cORIYtDb 9tYTiXsVfDb4bYgPVXsWhC47bMpNoCRNi+1r8Vub+NkeLbwn2bSnT7PRL6AkoTnpA+cQ +RtwhyUfcAy1zTRPR8XSIbPwctPrcAK1RL2T2ufUB8Bz7o3N0YIhH1SJqKwRkGOEQjxp xOxyTkC0bdPalo5ZqrrH3s9ulBIFOyKXCYGXKEx5fIE4NagcgMj5hLgMjBnWA9QnwI4K RjbK2MN1VQigBSMH7MbdmUCjXizdNQbSDuukyNyDrMkMI9qVVBH3B88vJJ/zduAQZYaI TQaw== X-Gm-Message-State: AFeK/H1ayYhYbF41hXP3nSxswh6XObC5eEv8RqLl/ZdJROp9rxhJYNOpX+P3t0Htys1Paw== X-Received: by 10.28.170.206 with SMTP id t197mr5293236wme.61.1490522187472; Sun, 26 Mar 2017 02:56:27 -0700 (PDT) Received: from bark.daynix ([141.226.163.173]) by smtp.gmail.com with ESMTPSA id r2sm9754754wmb.26.2017.03.26.02.56.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 26 Mar 2017 02:56:27 -0700 (PDT) From: Sameeh Jubran To: qemu-devel@nongnu.org, Michael Roth Date: Sun, 26 Mar 2017 12:56:22 +0300 Message-Id: <20170326095622.5105-1-sameeh@daynix.com> X-Mailer: git-send-email 2.9.3 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::243 Subject: [Qemu-devel] [PATCH qemu-ga v3] qga: Make qemu-ga compile statically for Windows X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yan Vugenfirer , Peter Maydell , Stefan Hajnoczi Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Attempting to compile qemu-ga statically as follows for Windows causes the following error: Compilation: ./configure --disable-docs --target-list=x86_64-softmmu \ --cross-prefix=x86_64-w64-mingw32- --static \ --enable-guest-agent-msi --with-vss-sdk=/path/to/VSSSDK72 make -j8 qemu-ga Error: path/to/qemu/stubs/error-printf.c:7: undefined reference to `__imp_g_test_config_vars' collect2: error: ld returned 1 exit status Makefile:444: recipe for target 'qemu-ga.exe' failed make: *** [qemu-ga.exe] Error 1 This is caused by a bug in the pkg-config file for glib as it doesn't define GLIB_STATIC_COMPILATION for pkg-config --static. Signed-off-by: Sameeh Jubran Reviewed-by: Stefan Hajnoczi --- configure | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/configure b/configure index b9a30cf..8210494 100755 --- a/configure +++ b/configure @@ -3041,6 +3041,13 @@ if test "$modules" = yes; then glib_modules="$glib_modules gmodule-2.0" fi +# This workaround is required due to a bug in pkg-config file for glib as it +# doesn't define GLIB_STATIC_COMPILATION for pkg-config --static + +if test "$static" = yes -a "$mingw32" = yes; then + QEMU_CFLAGS="-DGLIB_STATIC_COMPILATION $QEMU_CFLAGS" +fi + for i in $glib_modules; do if $pkg_config --atleast-version=$glib_req_ver $i; then glib_cflags=$($pkg_config --cflags $i)