From patchwork Tue Apr 4 10:23:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gerd Hoffmann X-Patchwork-Id: 9661269 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B97B8602B9 for ; Tue, 4 Apr 2017 10:32:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AB2892846D for ; Tue, 4 Apr 2017 10:32:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9E505284D1; Tue, 4 Apr 2017 10:32:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 285012846D for ; Tue, 4 Apr 2017 10:32:38 +0000 (UTC) Received: from localhost ([::1]:34854 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cvLlM-0000WH-P9 for patchwork-qemu-devel@patchwork.kernel.org; Tue, 04 Apr 2017 06:32:36 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54142) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cvLcY-00026p-LS for qemu-devel@nongnu.org; Tue, 04 Apr 2017 06:23:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cvLcT-0002Cy-Px for qemu-devel@nongnu.org; Tue, 04 Apr 2017 06:23:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27575) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cvLcT-0002Bp-Ko for qemu-devel@nongnu.org; Tue, 04 Apr 2017 06:23:25 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A7437BDD4; Tue, 4 Apr 2017 10:23:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A7437BDD4 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=kraxel@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com A7437BDD4 Received: from nilsson.home.kraxel.org (ovpn-116-84.ams2.redhat.com [10.36.116.84]) by smtp.corp.redhat.com (Postfix) with ESMTP id 49525881E4; Tue, 4 Apr 2017 10:23:24 +0000 (UTC) Received: by nilsson.home.kraxel.org (Postfix, from userid 500) id ECD7880DAD; Tue, 4 Apr 2017 12:23:20 +0200 (CEST) From: Gerd Hoffmann To: qemu-devel@nongnu.org Date: Tue, 4 Apr 2017 12:23:13 +0200 Message-Id: <20170404102315.24923-9-kraxel@redhat.com> In-Reply-To: <20170404102315.24923-1-kraxel@redhat.com> References: <20170404102315.24923-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 04 Apr 2017 10:23:24 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 08/10] tcx: introduce tcx_check_dirty() function X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Mark Cave-Ayland Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Mark Cave-Ayland This is similar to the existing tcx24_check_dirty() function and will aid with the transition to thread-safe updates. Signed-off-by: Mark Cave-Ayland --- hw/display/tcx.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/display/tcx.c b/hw/display/tcx.c index 8e26aae..15172f0 100644 --- a/hw/display/tcx.c +++ b/hw/display/tcx.c @@ -98,6 +98,12 @@ static void tcx_set_dirty(TCXState *s) memory_region_set_dirty(&s->vram_mem, 0, MAXX * MAXY); } +static inline int tcx_check_dirty(TCXState *s, ram_addr_t page) +{ + return memory_region_get_dirty(&s->vram_mem, page, TARGET_PAGE_SIZE, + DIRTY_MEMORY_VGA); +} + static inline int tcx24_check_dirty(TCXState *s, ram_addr_t page, ram_addr_t page24, ram_addr_t cpage) { @@ -359,8 +365,7 @@ static void tcx_update_display(void *opaque) memory_region_sync_dirty_bitmap(&ts->vram_mem); for (y = 0; y < ts->height; page += TARGET_PAGE_SIZE) { - if (memory_region_get_dirty(&ts->vram_mem, page, TARGET_PAGE_SIZE, - DIRTY_MEMORY_VGA)) { + if (tcx_check_dirty(ts, page)) { if (y_start < 0) y_start = y; if (page < page_min)