From patchwork Wed Apr 5 12:01:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sameeh Jubran X-Patchwork-Id: 9663849 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 40BF560353 for ; Wed, 5 Apr 2017 12:02:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2F8C427F90 for ; Wed, 5 Apr 2017 12:02:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2139228066; Wed, 5 Apr 2017 12:02:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 117F427F90 for ; Wed, 5 Apr 2017 12:02:06 +0000 (UTC) Received: from localhost ([::1]:40204 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cvjdV-00089I-NB for patchwork-qemu-devel@patchwork.kernel.org; Wed, 05 Apr 2017 08:02:05 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58494) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cvjcm-00088x-Ni for qemu-devel@nongnu.org; Wed, 05 Apr 2017 08:01:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cvjci-0001RH-2z for qemu-devel@nongnu.org; Wed, 05 Apr 2017 08:01:20 -0400 Received: from mail-wr0-x241.google.com ([2a00:1450:400c:c0c::241]:35955) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cvjch-0001Qp-SY for qemu-devel@nongnu.org; Wed, 05 Apr 2017 08:01:16 -0400 Received: by mail-wr0-x241.google.com with SMTP id k6so2036765wre.3 for ; Wed, 05 Apr 2017 05:01:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=aT1RK5Gbb+gUURFCCtyhG+USv5hP+OEh4052EWGRdOM=; b=eAeIUccGEFnfSoZIhG0QhoOtaWA1zsQg7kUtb25GPZr8WnkAWA3yRjp3RJbBUnFvgz a3BQj29bM2lgWYs2u/XCZwoNmHSzhPQ1hiuSVUdxHkd6MkCrZYDhQ2mptss6jYazPSxB SwdzpEfE4hW7Z8ybdqW7r7XE+Wo/2TGjnIIMzhq6pmcpNt/y1WaW3Gp9ndOjmfv/Z3OH N9rTWyPXdUp8vFGWWBk7h58tow2tktwQ3z1q7qRiujy71adXytYCQ7Cgmlzl/PiJWmHB MjGN1c2n/qyIha8TiwsmcWp/Yy8XSKOfjAgAibcCcH9uFNjVeyRJavCKib3m3KXL0zfi qt8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=aT1RK5Gbb+gUURFCCtyhG+USv5hP+OEh4052EWGRdOM=; b=jNd45skdEB32lIbxzdzAIX6Az1mpaUS0SDe4mEPChzhtKMutTW6VO1uGvLJzrreZGe X9a2MaRvtc8HALIsCJEUITI+QdXesdse4TuGfhT3cF4MjJ1oyy8yOG/7APRaViP3lz5q JLuKHu+ylG7a3IiZ1se17VkzukKH/8DoqeCFWTi8QK/BUlBdQQJChAYxTOAm8E3nl2hv 1kJJGFGg0Z1j2+ebX+InUoVcuaO0zbKQ9Ies0K5u3wtl86lxqOj1O/VPRhB1/jyeQ9M1 i+ipkZ/gV3Y+HUTUFeB0aXU0ECawNZygBbM/x6wFTli4WrjWlZY+eVIPb7jePaX22CWx iEww== X-Gm-Message-State: AFeK/H1gFfl2WkmeXhf4rYOVoEHmHrLYPEVzSKvnGyVfb7/lKZWA+svvqPE2Oncs2Aqanw== X-Received: by 10.28.232.14 with SMTP id f14mr9235355wmh.106.1491393674275; Wed, 05 Apr 2017 05:01:14 -0700 (PDT) Received: from bark.redhat.com ([141.226.163.173]) by smtp.gmail.com with ESMTPSA id j185sm153060wmg.23.2017.04.05.05.01.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Apr 2017 05:01:13 -0700 (PDT) From: Sameeh Jubran To: qemu-devel@nongnu.org, Michael Roth Date: Wed, 5 Apr 2017 15:01:06 +0300 Message-Id: <20170405120106.19298-1-sameeh@daynix.com> X-Mailer: git-send-email 2.9.3 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::241 Subject: [Qemu-devel] [PATCH v2] qga-win: Fix Event Viewer errors caused by qemu-ga X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yan Vugenfirer Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP When the command "guest-fsfreeze-freeze" is executed it causes the VSS service to log the error below in the Event Viewer. This error is caused by an issue in the function "CommitSnapshots" in provider.cpp: * When VSS_TIMEOUT_MSEC expires the funtion returns E_ABORT. This causes the error #12293. |event id| error | * 12293 : Volume Shadow Copy Service error: Error calling a routine on a Shadow Copy Provider {00000000-0000-0000-0000-000000000000}. Routine details CommitSnapshots [hr = 0x80004004, Operation aborted. Signed-off-by: Sameeh Jubran --- qga/vss-win32/provider.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/qga/vss-win32/provider.cpp b/qga/vss-win32/provider.cpp index ef94669..72d8b0e 100644 --- a/qga/vss-win32/provider.cpp +++ b/qga/vss-win32/provider.cpp @@ -377,7 +377,6 @@ STDMETHODIMP CQGAVssProvider::CommitSnapshots(VSS_ID SnapshotSetId) if (WaitForSingleObject(hEventThaw, VSS_TIMEOUT_MSEC) != WAIT_OBJECT_0) { /* Send event to qemu-ga to notify the provider is timed out */ SetEvent(hEventTimeout); - hr = E_ABORT; } CloseHandle(hEventThaw);