From patchwork Fri Apr 7 22:20:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 9670605 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9ABBA602A0 for ; Fri, 7 Apr 2017 22:22:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8B15E28624 for ; Fri, 7 Apr 2017 22:22:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7C6B128643; Fri, 7 Apr 2017 22:22:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id DD4A928624 for ; Fri, 7 Apr 2017 22:22:42 +0000 (UTC) Received: from localhost ([::1]:52780 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cwcHB-0007zx-JD for patchwork-qemu-devel@patchwork.kernel.org; Fri, 07 Apr 2017 18:22:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39993) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cwcFl-0007vf-OK for qemu-devel@nongnu.org; Fri, 07 Apr 2017 18:21:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cwcFj-00051V-3z for qemu-devel@nongnu.org; Fri, 07 Apr 2017 18:21:13 -0400 Received: from mail-qt0-x244.google.com ([2607:f8b0:400d:c0d::244]:35381) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cwcFi-00051M-WC; Fri, 07 Apr 2017 18:21:11 -0400 Received: by mail-qt0-x244.google.com with SMTP id r5so11572805qtb.2; Fri, 07 Apr 2017 15:21:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=roO5S6VZ+7cwj/eu4jG7oLhUYwUiPPLY4V0rpI9ScD8=; b=OgEgL3INvwH1ve2s52yZpcZ7KDxaCDabZC6MR6EpFj163Mz3fChal44BJim7+xZd4Y O22YfbMYa1A26ftz9iMcSBXQP0dr/R7fCHeSLzakSVCTO8hrZP9hHnrm5N/dWv3R7nBu YIhbo+YqfkEj9w5Zy7sElxs+o43DAWW43a0E0LegVGqffDKROSh+ai1oZ9RBlwMn0HsJ F875HmeMKvdQfp0/QGKodfMKN6motDVnpmvs4Pjs4/ewxf+vsuzOCOYLyraKYZaxswRH YYbaabHKCvd7s79JPWPc5ed4R0QR9meadvdFkzpeUrr5OUSgGvYp96HpsjZbZApX6HxD yrEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=roO5S6VZ+7cwj/eu4jG7oLhUYwUiPPLY4V0rpI9ScD8=; b=D6WTG4clJGeIACfcb9/NlyUfmR7ZGnGOTo9jzsXuxDUlUGUG569O+0k9YEYboFN+Dg qBJIihFGlio0EHUz/x7jgU269DMMOJ473Ww0oI3QcDXYQMFRoEJz2hqUmNYXsR0PZlpS 2Ht4tLPQ9PBoZIUzbSw7H+txGhkV8T/xvULHy7knO/8byN3c3cBWh9LF2+iEvb9kV27t PixHVAAkY0j3tpDYJku41XqooB48AFYy1vI6AJDGNe8aBPSC0PQzDsopsTJ4pH+FGVdL I3oW9zrE3x3jrAqATvJpCumuqtlbXe4H8FpsMGNpeKt4pIvg5CYbvvA7JuTi5ddRmyt3 Jeuw== X-Gm-Message-State: AN3rC/7KeXmdOsVsxOFDPN1JC3VrTcNxkuoVAdIIMblCZ1LTLK3Gyzf5iA0jIlfsiGB+7g== X-Received: by 10.237.63.69 with SMTP id q5mr537208qtf.236.1491603670511; Fri, 07 Apr 2017 15:21:10 -0700 (PDT) Received: from yoga.lan ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id d133sm1442146qke.9.2017.04.07.15.21.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Apr 2017 15:21:09 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Gerd Hoffmann , Markus Armbruster , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Date: Fri, 7 Apr 2017 19:20:13 -0300 Message-Id: <20170407222016.15308-2-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170407222016.15308-1-f4bug@amsat.org> References: <20170407222016.15308-1-f4bug@amsat.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c0d::244 Subject: [Qemu-devel] [PATCH v2 1/4] usb-ccid: make ccid_write_data_block() cope with null buffers X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP static code analyzer complain: hw/usb/dev-smartcard-reader.c:816:5: warning: Null pointer passed as an argument to a 'nonnull' parameter memcpy(p->abData, data, len); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé --- hw/usb/dev-smartcard-reader.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c index 757b8b3f5a..49cb1829b5 100644 --- a/hw/usb/dev-smartcard-reader.c +++ b/hw/usb/dev-smartcard-reader.c @@ -813,7 +813,10 @@ static void ccid_write_data_block(USBCCIDState *s, uint8_t slot, uint8_t seq, if (p->b.bError) { DPRINTF(s, D_VERBOSE, "error %d\n", p->b.bError); } - memcpy(p->abData, data, len); + if (len) { + g_assert_nonnull(data); + memcpy(p->abData, data, len); + } ccid_reset_error_status(s); usb_wakeup(s->bulk, 0); }