diff mbox

[v10,06/17] qemu-io: Don't open-code QEMU_IS_ALIGNED

Message ID 20170427014626.11553-7-eblake@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Eric Blake April 27, 2017, 1:46 a.m. UTC 
Manual comparison against 0x1ff is not as clean as using our
alignment macros from osdep.h.

Suggested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Eric Blake <eblake@redhat.com>

---
v10: new patch
---
 qemu-io-cmds.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Max Reitz April 28, 2017, 7:30 p.m. UTC | #1 
On 27.04.2017 03:46, Eric Blake wrote:
> Manual comparison against 0x1ff is not as clean as using our
> alignment macros from osdep.h.
> 
> Suggested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> 
> ---
> v10: new patch
> ---
>  qemu-io-cmds.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>
diff mbox

Patch

diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c
index 21af9e6..fabc394 100644
--- a/qemu-io-cmds.c
+++ b/qemu-io-cmds.c
@@ -740,12 +740,12 @@  static int read_f(BlockBackend *blk, int argc, char **argv)
     }

     if (bflag) {
-        if (offset & 0x1ff) {
+        if (!QEMU_IS_ALIGNED(offset, BDRV_SECTOR_SIZE)) {
             printf("offset %" PRId64 " is not sector aligned\n",
                    offset);
             return 0;
         }
-        if (count & 0x1ff) {
+        if (!QEMU_IS_ALIGNED(count, BDRV_SECTOR_SIZE)) {
             printf("count %"PRId64" is not sector aligned\n",
                    count);
             return 0;
@@ -1050,13 +1050,13 @@  static int write_f(BlockBackend *blk, int argc, char **argv)
     }

     if (bflag || cflag) {
-        if (offset & 0x1ff) {
+        if (!QEMU_IS_ALIGNED(offset, BDRV_SECTOR_SIZE)) {
             printf("offset %" PRId64 " is not sector aligned\n",
                    offset);
             return 0;
         }

-        if (count & 0x1ff) {
+        if (!QEMU_IS_ALIGNED(count, BDRV_SECTOR_SIZE)) {
             printf("count %"PRId64" is not sector aligned\n",
                    count);
             return 0;
@@ -1769,7 +1769,7 @@  static int alloc_f(BlockBackend *blk, int argc, char **argv)
     if (offset < 0) {
         print_cvtnum_err(offset, argv[1]);
         return 0;
-    } else if (offset & 0x1ff) {
+    } else if (!QEMU_IS_ALIGNED(offset, BDRV_SECTOR_SIZE)) {
         printf("offset %" PRId64 " is not sector aligned\n",
                offset);
         return 0;