From patchwork Wed May 10 20:05:30 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 9720619 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 798E760364 for ; Wed, 10 May 2017 20:07:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 91B3428600 for ; Wed, 10 May 2017 20:07:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 85EB028639; Wed, 10 May 2017 20:07:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 11C8128600 for ; Wed, 10 May 2017 20:07:35 +0000 (UTC) Received: from localhost ([::1]:44583 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8XtV-0008DJ-TO for patchwork-qemu-devel@patchwork.kernel.org; Wed, 10 May 2017 16:07:34 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8XsC-0008Aw-Qc for qemu-devel@nongnu.org; Wed, 10 May 2017 16:06:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8XsB-0006Sh-Mw for qemu-devel@nongnu.org; Wed, 10 May 2017 16:06:12 -0400 Received: from mail-qt0-x243.google.com ([2607:f8b0:400d:c0d::243]:36784) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d8XsB-0006SN-Gi; Wed, 10 May 2017 16:06:11 -0400 Received: by mail-qt0-x243.google.com with SMTP id j13so264863qta.3; Wed, 10 May 2017 13:06:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CUtuhwotTcUgfxDileQ4JAC48wEk/mlZ5pDz05j4+8k=; b=pGATNv47uqxnzp531GYbfYMMr8ohYIc7++5BNz4OSZwvMcunbqxFvsnashbgGEpivw vuayFUbmftwhTOEA6X+/snQMkdjvJcpljWUYbk+bqBl6/cqPiEpfGxmnXZPt1s9s6YRk LDXfL4cSqkKoMqADSE6aj+PmcI2GzvbA8u3i4YU3SZxS7Z2ALSup9L04pgc8U6iMAXNO 44wNwy7XZlSoay4pKPpPyjAtSkl53HKj4ZFV9LyERz3CAkEyRdFNZVi9ckR3O2Xa4FOR nOdh4WskYzBQYG00Zmnas+0xfQTWwEIaUiihF973dDYdwyFXSSsIddQXm5phbXxwx+Wj amLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=CUtuhwotTcUgfxDileQ4JAC48wEk/mlZ5pDz05j4+8k=; b=kfIk+uz3/x7mXDVxv876qUgbtyb6lw5bcEb3Iav5zf3gfwvzZa4ddzMvZKySMKcd2P q7ykKkoHrk7bm0BNtQmxT9eDSOAnzCS/PHdhRreqx53qS7pJ9USa0CImdtbzc8LknlKY IGWpWpvMAyx0qaGMaaFCPAkzIHH9XibdA7EpTs9bP2m3Md9ffEKVWdW56kq9VIPSKGIf 0CoX9Y2AQMj0oeB50NgGcF4PRthwVEOBpV8DFF2YM8WQ8PKxbrKW4V3TZXjhRhaPlvTu RaXdXEr1M381iDMzCtrQQpSwcp/ipf88Ug7tytq+KN/7Z+NcSooOvNIKr+cAveGj+Gcq GYtw== X-Gm-Message-State: AODbwcDEIa6KZrAKiF0pYOYDrZICsFuQqRq40e+OvzA/e7JZx9JrwnTj LiaZUTtMBIuw8Q== X-Received: by 10.200.43.217 with SMTP id n25mr307105qtn.190.1494446771064; Wed, 10 May 2017 13:06:11 -0700 (PDT) Received: from localhost.localdomain ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id s190sm377398qkh.57.2017.05.10.13.06.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 May 2017 13:06:10 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Peter Maydell , Aurelien Jarno , Richard Henderson , qemu-arm@nongnu.org Date: Wed, 10 May 2017 17:05:30 -0300 Message-Id: <20170510200535.13268-4-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170510200535.13268-1-f4bug@amsat.org> References: <20170510200535.13268-1-f4bug@amsat.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::243 Subject: [Qemu-devel] [PATCH 3/8] target/arm: optimize rev16() using extract op X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Applied using Coccinelle script. Signed-off-by: Philippe Mathieu-Daudé --- target/arm/translate-a64.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 24de30d92c..7ea130107e 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -4038,14 +4038,12 @@ static void handle_rev16(DisasContext *s, unsigned int sf, tcg_gen_andi_i64(tcg_tmp, tcg_rn, 0xffff); tcg_gen_bswap16_i64(tcg_rd, tcg_tmp); - tcg_gen_shri_i64(tcg_tmp, tcg_rn, 16); - tcg_gen_andi_i64(tcg_tmp, tcg_tmp, 0xffff); + tcg_gen_extract_i64(tcg_tmp, tcg_rn, 16, 0xffff); tcg_gen_bswap16_i64(tcg_tmp, tcg_tmp); tcg_gen_deposit_i64(tcg_rd, tcg_rd, tcg_tmp, 16, 16); if (sf) { - tcg_gen_shri_i64(tcg_tmp, tcg_rn, 32); - tcg_gen_andi_i64(tcg_tmp, tcg_tmp, 0xffff); + tcg_gen_extract_i64(tcg_tmp, tcg_rn, 32, 0xffff); tcg_gen_bswap16_i64(tcg_tmp, tcg_tmp); tcg_gen_deposit_i64(tcg_rd, tcg_rd, tcg_tmp, 32, 16);