From patchwork Wed May 10 20:05:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 9720627 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F24EA60236 for ; Wed, 10 May 2017 20:11:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 143E42863D for ; Wed, 10 May 2017 20:11:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0792828640; Wed, 10 May 2017 20:11:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 784D02863D for ; Wed, 10 May 2017 20:11:28 +0000 (UTC) Received: from localhost ([::1]:44606 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8XxH-0003cD-IV for patchwork-qemu-devel@patchwork.kernel.org; Wed, 10 May 2017 16:11:27 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8XsL-0008Ic-FD for qemu-devel@nongnu.org; Wed, 10 May 2017 16:06:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8XsI-0006W2-8M for qemu-devel@nongnu.org; Wed, 10 May 2017 16:06:21 -0400 Received: from mail-qt0-x244.google.com ([2607:f8b0:400d:c0d::244]:35794) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d8XsI-0006Vr-4H for qemu-devel@nongnu.org; Wed, 10 May 2017 16:06:18 -0400 Received: by mail-qt0-x244.google.com with SMTP id r58so271160qtb.2 for ; Wed, 10 May 2017 13:06:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4cetlFfxvnoF3a93mvYF4nJD6Cnt6x6Jtg4fH3YplO4=; b=BENAgRYfThqX6NLxB7JcFf2M+ndkrJxGRlTsVwQ2AiwcOboR0EjB8cudSD23GfbzQp b3Yic+KzKqRtPD/0UhhcVGKktk23/lChiGdaFeLBSq2et2Wx9QNbF6cICQjAkwDN70wD 5Nuk9i8qcekUq4H0wo4ZAp9lSKcEM+gXAOH8NNiif02sAbiJP600/u1sec9NCSQhJ2g2 vDoa1PANv6AYkI0LIsiA7hTAPT45Tb6PVr5EvcsDPvogh7Yd2ZT3O2LoUv9E1O+td2Mp XeAOP+Wguw15WLDi7KOVITsIBQ7nG/uwc0R/hFnPhuLXPvf5EMKwWgu87NP2ryfYWx/a SAGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=4cetlFfxvnoF3a93mvYF4nJD6Cnt6x6Jtg4fH3YplO4=; b=flVqLYAhXniJGJoderj29eX/gMN5EMzInIhwivJz2qI17CRowwI3f2AJH+4YhVDMhH zFR1FM8BUNRWk3IXgECQy54QlBf3n4fA6XyGc7+q5C+mqj+vthy136Blott4l27cUEcC kYq6zysqb+POJRi+hb4NllsRfDrOVfy2x0kq+IkWHOGIEYqgkRsNSHjaZ1tS16hszolj BN3hgazonG3d2GTB5rcSK38zaBHD9PrsqKWNhdNsmYblO7lVNdcyQyvs12Zd8dajTlMN p8K71MTAoSAAuJvMI2XVgGNm3fcw11BuDdzpOc3Mnty/WGDGW+7cZXqP5ZIGy8uCvxRS q/Dw== X-Gm-Message-State: AODbwcDe4wJUyCgLCep2Hrr7Q2t3SUTuvRtMVDVwH9vHOBLp64gg8IDA LQMH+hHkPvndIA== X-Received: by 10.200.57.37 with SMTP id s34mr274257qtb.141.1494446777575; Wed, 10 May 2017 13:06:17 -0700 (PDT) Received: from localhost.localdomain ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id s190sm377398qkh.57.2017.05.10.13.06.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 May 2017 13:06:17 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Aurelien Jarno , Richard Henderson , Yongbok Kim Date: Wed, 10 May 2017 17:05:33 -0300 Message-Id: <20170510200535.13268-7-f4bug@amsat.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170510200535.13268-1-f4bug@amsat.org> References: <20170510200535.13268-1-f4bug@amsat.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::244 Subject: [Qemu-devel] [PATCH 6/8] target/mips: optimize bshfl() using extract op X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Applied using Coccinelle script. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/translate.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 3022f349cb..96177da9ae 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -4573,8 +4573,7 @@ static void gen_bshfl (DisasContext *ctx, uint32_t op2, int rt, int rd) { TCGv t1 = tcg_temp_new(); - tcg_gen_shri_tl(t1, t0, 8); - tcg_gen_andi_tl(t1, t1, 0x00FF00FF); + tcg_gen_extract_tl(t1, t0, 8, 0x00FF00FF); tcg_gen_shli_tl(t0, t0, 8); tcg_gen_andi_tl(t0, t0, ~0x00FF00FF); tcg_gen_or_tl(t0, t0, t1); @@ -4593,8 +4592,7 @@ static void gen_bshfl (DisasContext *ctx, uint32_t op2, int rt, int rd) { TCGv t1 = tcg_temp_new(); - tcg_gen_shri_tl(t1, t0, 8); - tcg_gen_andi_tl(t1, t1, 0x00FF00FF00FF00FFULL); + tcg_gen_extract_tl(t1, t0, 8, 0x00FF00FF00FF00FFULL); tcg_gen_shli_tl(t0, t0, 8); tcg_gen_andi_tl(t0, t0, ~0x00FF00FF00FF00FFULL); tcg_gen_or_tl(cpu_gpr[rd], t0, t1); @@ -4605,8 +4603,7 @@ static void gen_bshfl (DisasContext *ctx, uint32_t op2, int rt, int rd) { TCGv t1 = tcg_temp_new(); - tcg_gen_shri_tl(t1, t0, 16); - tcg_gen_andi_tl(t1, t1, 0x0000FFFF0000FFFFULL); + tcg_gen_extract_tl(t1, t0, 16, 0x0000FFFF0000FFFFULL); tcg_gen_shli_tl(t0, t0, 16); tcg_gen_andi_tl(t0, t0, ~0x0000FFFF0000FFFFULL); tcg_gen_or_tl(t0, t0, t1);