From patchwork Fri May 12 18:21:32 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Aurelien Jarno X-Patchwork-Id: 9724753 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CD44B60382 for ; Fri, 12 May 2017 18:22:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C442B20243 for ; Fri, 12 May 2017 18:22:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B70E926E47; Fri, 12 May 2017 18:22:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id BA14F20243 for ; Fri, 12 May 2017 18:22:28 +0000 (UTC) Received: from localhost ([::1]:54851 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d9FCs-0004gx-Uy for patchwork-qemu-devel@patchwork.kernel.org; Fri, 12 May 2017 14:22:26 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51452) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d9FCJ-0004gd-Di for qemu-devel@nongnu.org; Fri, 12 May 2017 14:21:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d9FCI-0007l2-0L for qemu-devel@nongnu.org; Fri, 12 May 2017 14:21:51 -0400 Received: from hall.aurel32.net ([2001:bc8:30d7:100::1]:38856) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d9FCH-0007gY-Qc; Fri, 12 May 2017 14:21:49 -0400 Received: from [2001:bc8:30d7:120:9bb5:8936:7e6a:9e36] (helo=ohm.rr44.fr) by hall.aurel32.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1d9FC3-0003of-UJ; Fri, 12 May 2017 20:21:36 +0200 Received: from aurel32 by ohm.rr44.fr with local (Exim 4.89) (envelope-from ) id 1d9FC0-00075N-Dj; Fri, 12 May 2017 20:21:32 +0200 Date: Fri, 12 May 2017 20:21:32 +0200 From: Aurelien Jarno To: Richard Henderson Message-ID: <20170512182132.jdw4g2pd5gvf2dti@aurel32.net> References: <20170512033543.6789-1-f4bug@amsat.org> <20170512033543.6789-3-f4bug@amsat.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:bc8:30d7:100::1 Subject: Re: [Qemu-devel] [PATCH v3 2/5] target/arm: optimize rev16() using extract op X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-arm@nongnu.org, Philippe =?iso-8859-15?Q?Mathieu-Daud=E9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP On 2017-05-12 09:50, Richard Henderson wrote: > On 05/11/2017 08:35 PM, Philippe Mathieu-Daudé wrote: > > - tcg_gen_shri_i64(tcg_tmp, tcg_rn, 16); > > - tcg_gen_andi_i64(tcg_tmp, tcg_tmp, 0xffff); > > + tcg_gen_extract_i64(tcg_tmp, tcg_rn, 16, 0xffff); > > So your new script didn't work then? This should be "..., 16, 16);". Indeed that should be ..., 16, 16). That said looking a bit at the actual code, it looks like rev16 is not implemented efficiently. Instead of byteswapping individual 16-bit words one by one, it would be better to work on the whole register at the same time using shifts and mask. This is actually how rev16 is implemented for aarch32 (and a few other targets). Something like that (i can send a proper patch later): This makes the generated x86-64 code much shorter, especially with sf=1: * rev16 with sf = 0 before: 0x5631ecfda582: movzwl %bx,%r12d 0x5631ecfda586: rol $0x8,%r12w 0x5631ecfda58b: shr $0x10,%rbx 0x5631ecfda58f: rol $0x8,%bx 0x5631ecfda593: movzwl %bx,%ebx 0x5631ecfda596: shl $0x10,%rbx 0x5631ecfda59a: mov $0xffffffff0000ffff,%r13 0x5631ecfda5a4: and %r13,%r12 0x5631ecfda5a7: or %rbx,%r12 after: 0x559f7aeae5f2: mov %rbx,%r12 0x559f7aeae5f5: shr $0x8,%r12 0x559f7aeae5f9: and $0xff00ff,%r12d 0x559f7aeae600: shl $0x8,%rbx 0x559f7aeae604: and $0xff00ff00,%ebx 0x559f7aeae60a: or %r12,%rbx * rev16 with sf = 1 before: 0x5631ecfe5380: mov %rbx,%r12 0x5631ecfe5383: movzwl %bx,%ebx 0x5631ecfe5386: rol $0x8,%bx 0x5631ecfe538a: mov %r12,%r13 0x5631ecfe538d: shr $0x10,%r13 0x5631ecfe5391: movzwl %r13w,%r13d 0x5631ecfe5395: rol $0x8,%r13w 0x5631ecfe539a: movzwl %r13w,%r13d 0x5631ecfe539e: shl $0x10,%r13 0x5631ecfe53a2: mov $0xffffffff0000ffff,%r15 0x5631ecfe53ac: and %r15,%rbx 0x5631ecfe53af: or %r13,%rbx 0x5631ecfe53b2: mov %r12,%r13 0x5631ecfe53b5: shr $0x20,%r13 0x5631ecfe53b9: movzwl %r13w,%r13d 0x5631ecfe53bd: rol $0x8,%r13w 0x5631ecfe53c2: movzwl %r13w,%r13d 0x5631ecfe53c6: shl $0x20,%r13 0x5631ecfe53ca: mov $0xffff0000ffffffff,%r15 0x5631ecfe53d4: and %r15,%rbx 0x5631ecfe53d7: or %r13,%rbx 0x5631ecfe53da: shr $0x30,%r12 0x5631ecfe53de: rol $0x8,%r12w 0x5631ecfe53e3: shl $0x30,%r12 0x5631ecfe53e7: mov $0xffffffffffff,%r13 0x5631ecfe53f1: and %r13,%rbx 0x5631ecfe53f4: or %r12,%rbx after: 0x559f7aeb93e0: mov %rbx,%r12 0x559f7aeb93e3: shr $0x8,%r12 0x559f7aeb93e7: mov $0xff00ff00ff00ff,%r13 0x559f7aeb93f1: and %r13,%r12 0x559f7aeb93f4: shl $0x8,%rbx 0x559f7aeb93f8: mov $0xff00ff00ff00ff00,%r13 0x559f7aeb9402: and %r13,%rbx 0x559f7aeb9405: or %r12,%rbx Aurelien diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 24de30d92c..ccb276417b 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -4034,25 +4034,14 @@ static void handle_rev16(DisasContext *s, unsigned int sf, TCGv_i64 tcg_rd = cpu_reg(s, rd); TCGv_i64 tcg_tmp = tcg_temp_new_i64(); TCGv_i64 tcg_rn = read_cpu_reg(s, rn, sf); - - tcg_gen_andi_i64(tcg_tmp, tcg_rn, 0xffff); - tcg_gen_bswap16_i64(tcg_rd, tcg_tmp); - - tcg_gen_shri_i64(tcg_tmp, tcg_rn, 16); - tcg_gen_andi_i64(tcg_tmp, tcg_tmp, 0xffff); - tcg_gen_bswap16_i64(tcg_tmp, tcg_tmp); - tcg_gen_deposit_i64(tcg_rd, tcg_rd, tcg_tmp, 16, 16); - - if (sf) { - tcg_gen_shri_i64(tcg_tmp, tcg_rn, 32); - tcg_gen_andi_i64(tcg_tmp, tcg_tmp, 0xffff); - tcg_gen_bswap16_i64(tcg_tmp, tcg_tmp); - tcg_gen_deposit_i64(tcg_rd, tcg_rd, tcg_tmp, 32, 16); - - tcg_gen_shri_i64(tcg_tmp, tcg_rn, 48); - tcg_gen_bswap16_i64(tcg_tmp, tcg_tmp); - tcg_gen_deposit_i64(tcg_rd, tcg_rd, tcg_tmp, 48, 16); - } + uint64_t mask1 = sf ? 0x00ff00ff00ff00ffull : 0x00ff00ff; + uint64_t mask2 = sf ? 0xff00ff00ff00ff00ull : 0xff00ff00; + + tcg_gen_shri_i64(tcg_tmp, tcg_rn, 8); + tcg_gen_andi_i64(tcg_tmp, tcg_tmp, mask1); + tcg_gen_shli_i64(tcg_rd, tcg_rn, 8); + tcg_gen_andi_i64(tcg_rd, tcg_rd, mask2); + tcg_gen_or_i64(tcg_rd, tcg_rd, tcg_tmp); tcg_temp_free_i64(tcg_tmp); }