From patchwork Thu Jun 1 12:47:46 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Lamprecht X-Patchwork-Id: 9759585 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0B25A60375 for ; Thu, 1 Jun 2017 13:08:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EC230205F7 for ; Thu, 1 Jun 2017 13:08:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DF4512849F; Thu, 1 Jun 2017 13:08:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 28095205F7 for ; Thu, 1 Jun 2017 13:08:03 +0000 (UTC) Received: from localhost ([::1]:44267 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dGPpa-0008Ne-Tu for patchwork-qemu-devel@patchwork.kernel.org; Thu, 01 Jun 2017 09:08:03 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35447) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dGPc6-0005iq-FR for qemu-devel@nongnu.org; Thu, 01 Jun 2017 08:54:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dGPc2-0001C7-Lc for qemu-devel@nongnu.org; Thu, 01 Jun 2017 08:54:06 -0400 Received: from proxmox.maurer-it.com ([212.186.127.180]:22220) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dGPc2-0001Br-D8 for qemu-devel@nongnu.org; Thu, 01 Jun 2017 08:54:02 -0400 Received: from proxmox.maurer-it.com (localhost [127.0.0.1]) by proxmox.maurer-it.com (Proxmox) with ESMTP id E5F8C110E92B; Thu, 1 Jun 2017 14:48:14 +0200 (CEST) From: Thomas Lamprecht To: qemu-devel@nongnu.org Date: Thu, 1 Jun 2017 14:47:46 +0200 Message-Id: <20170601124746.32140-1-t.lamprecht@proxmox.com> X-Mailer: git-send-email 2.11.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 212.186.127.180 Subject: [Qemu-devel] [RFC 1/1] qemu-ga: add missing libpcre to MSI build X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Weil , Michael Roth Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP glib depends on libpcre which was not shipped with the MSI, thus starting of the qemu-ga.exe failed with the respective error message. Tell WIXL to ship this library with the MSI to avoid this problem. Signed-off-by: Thomas Lamprecht CC: Stefan Weil CC: Michael Roth --- I haven't done much with the qga or WIXL, so I send this as a RFC. I hope that I guessed the right people to get CC'ed from MAINTAINERS. This fixes a current qemu-ga MSI build, I tested it successfully with Windows 7 and Windows 10 as guest OS. I cross built from a Fedora 25 LXC container. The Guid for the libpcre was generated by https://www.guidgen.com/ as suggested by: http://wixtoolset.org/documentation/manual/v3/howtos/general/generate_guids.html qga/installer/qemu-ga.wxs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs index fa2260cafa..5af11627f8 100644 --- a/qga/installer/qemu-ga.wxs +++ b/qga/installer/qemu-ga.wxs @@ -125,6 +125,9 @@ + + + @@ -173,6 +176,7 @@ +