About remove the TCG related code in hw/i386/kvmvapic.c!

Commit Message

Yang Zhong June 14, 2017, 3:22 a.m. UTC

Hello Paolo,

About you below A20 fixed patch has been merged in QEMU latest release,

commit bbfa326fc8028e275eddf8c9965c2a1b59405b2e
target/i386: enable A20 automatically in system management mod 

I also disabled the kvmvapic rom with below patch and use qemu command to verify your patch

#disable kvmapic rom patch

#the pure tcg to boot image
./qemu-system-x86_64 -m 2G -smp cpus=4,cores=4,threads=1,sockets=1 -drive format=raw,file=eywa.img,index=0,media=disk -nographic -serial stdio -nodefaults

The image can be booted up normally now.

This verification show the TCG related code in kvmvapic.c file are NOT useful, my plan is to delete those TCG code in kvmvapic.c file, what's your comments?  Many thanks!


Regards,

Yang

Patch

diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c
index 1ef56f8..72c5bd6 100644
--- a/hw/intc/apic_common.c
+++ b/hw/intc/apic_common.c
@@ -440,7 +440,7 @@  static const VMStateDescription vmstate_apic_common = {
 static Property apic_properties_common[] = {
     DEFINE_PROP_UINT8("version", APICCommonState, version, 0x14),
     DEFINE_PROP_BIT("vapic", APICCommonState, vapic_control, VAPIC_ENABLE_BIT,
-                    true),
+                    false),
     DEFINE_PROP_BOOL("legacy-instance-id", APICCommonState, legacy_instance_id,
                      false),
     DEFINE_PROP_END_OF_LIST(),