From patchwork Wed Jun 14 03:22:32 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Zhong X-Patchwork-Id: 9785187 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B9B08602C9 for ; Wed, 14 Jun 2017 03:23:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7F0142852A for ; Wed, 14 Jun 2017 03:23:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 71B6528539; Wed, 14 Jun 2017 03:23:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 080A52852A for ; Wed, 14 Jun 2017 03:23:25 +0000 (UTC) Received: from localhost ([::1]:46186 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dKytx-00044E-5K for patchwork-qemu-devel@patchwork.kernel.org; Tue, 13 Jun 2017 23:23:25 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dKytJ-00043x-B2 for qemu-devel@nongnu.org; Tue, 13 Jun 2017 23:22:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dKytG-0003gI-1X for qemu-devel@nongnu.org; Tue, 13 Jun 2017 23:22:45 -0400 Received: from mga01.intel.com ([192.55.52.88]:57825) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dKytF-0003dC-Ot for qemu-devel@nongnu.org; Tue, 13 Jun 2017 23:22:41 -0400 Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jun 2017 20:22:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,340,1493708400"; d="scan'208";a="114631980" Received: from yangzhon-virtual.bj.intel.com (HELO localhost) ([10.238.145.52]) by fmsmga006.fm.intel.com with ESMTP; 13 Jun 2017 20:22:38 -0700 Date: Wed, 14 Jun 2017 11:22:32 +0800 From: Zhong Yang To: Paolo Bonzini Message-ID: <20170614032232.GA1330@yangzhon-Virtual> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.88 Subject: [Qemu-devel] About remove the TCG related code in hw/i386/kvmvapic.c! X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yang.zhong@intel.com, anthony.xu@intel.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Hello Paolo, About you below A20 fixed patch has been merged in QEMU latest release, commit bbfa326fc8028e275eddf8c9965c2a1b59405b2e target/i386: enable A20 automatically in system management mod I also disabled the kvmvapic rom with below patch and use qemu command to verify your patch #disable kvmapic rom patch #the pure tcg to boot image ./qemu-system-x86_64 -m 2G -smp cpus=4,cores=4,threads=1,sockets=1 -drive format=raw,file=eywa.img,index=0,media=disk -nographic -serial stdio -nodefaults The image can be booted up normally now. This verification show the TCG related code in kvmvapic.c file are NOT useful, my plan is to delete those TCG code in kvmvapic.c file, what's your comments? Many thanks! Regards, Yang diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c index 1ef56f8..72c5bd6 100644 --- a/hw/intc/apic_common.c +++ b/hw/intc/apic_common.c @@ -440,7 +440,7 @@ static const VMStateDescription vmstate_apic_common = { static Property apic_properties_common[] = { DEFINE_PROP_UINT8("version", APICCommonState, version, 0x14), DEFINE_PROP_BIT("vapic", APICCommonState, vapic_control, VAPIC_ENABLE_BIT, - true), + false), DEFINE_PROP_BOOL("legacy-instance-id", APICCommonState, legacy_instance_id, false), DEFINE_PROP_END_OF_LIST(),