From patchwork Tue Jul 4 09:38:15 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Richard W.M. Jones" X-Patchwork-Id: 9824439 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1545E604D9 for ; Tue, 4 Jul 2017 09:41:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 062CE20453 for ; Tue, 4 Jul 2017 09:41:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EF16726E16; Tue, 4 Jul 2017 09:41:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6BE912223E for ; Tue, 4 Jul 2017 09:41:36 +0000 (UTC) Received: from localhost ([::1]:39921 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKKt-0006Wx-K0 for patchwork-qemu-devel@patchwork.kernel.org; Tue, 04 Jul 2017 05:41:35 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35770) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSKHt-0004Ra-Kp for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:38:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSKHs-00017n-QI for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:38:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59902) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dSKHs-000179-Jz for qemu-devel@nongnu.org; Tue, 04 Jul 2017 05:38:28 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7588BC058EC7 for ; Tue, 4 Jul 2017 09:38:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7588BC058EC7 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=rjones@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 7588BC058EC7 Received: from moo.home.annexia.org (ovpn-116-210.ams2.redhat.com [10.36.116.210]) by smtp.corp.redhat.com (Postfix) with ESMTP id F140363F7E; Tue, 4 Jul 2017 09:38:18 +0000 (UTC) From: "Richard W.M. Jones" To: qemu-devel@nongnu.org Date: Tue, 4 Jul 2017 10:38:15 +0100 Message-Id: <20170704093815.28285-1-rjones@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 04 Jul 2017 09:38:26 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] checkpatch: Error if signal(2) is used non-portably. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, armbru@redhat.com Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP The only portable use for signal(2) is setting a signal to SIG_IGN or SIG_DFL. Everything else is a portability minefield. This change adds such a check to checkpatch. It gives an error like this: ERROR: Use sigaction instead of signal, except when setting the handler to SIG_IGN or SIG_DFL #39: FILE: qemu-nbd.c:585: + signal(SIGPIPE, foobar); total: 1 errors, 0 warnings, 10 lines checked Signed-off-by: Richard W.M. Jones --- scripts/checkpatch.pl | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 45027b9281..76a2a87b25 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2593,6 +2593,15 @@ sub process { $line =~ /\b(?:$non_exit_glib_asserts)\(/) { ERROR("Use g_assert or g_assert_not_reached\n". $herecurr); } + +# signal(2) can only portably be used for SIG_IGN or SIG_DFL. For +# everything else, sigaction should be used instead. + if ($line =~ /\bsignal\([^,]+, ([^,\)]+)/ && + $1 !~ /^SIG_(IGN|DFL)$/) { + ERROR("Use sigaction instead of signal, ". + "except when setting the handler to ". + "SIG_IGN or SIG_DFL\n" . $herecurr); + } } # If we have no input at all, then there is nothing to report on