diff mbox

[RFC,1/3] tests/vhost-user-bridge: disable debug output by default

Message ID 20170712094149.23069-2-jfreimann@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jens Freimann July 12, 2017, 9:41 a.m. UTC 
From: Jens Freimann <jfreiman@redhat.com>

vhost-user-bridge prints out a lot of information, including dumps
of all transmitted data. When called from a testcase this output
clutters the actual test results, so let's make the default no debug
output.

Signed-off-by: Jens Freimann <jfreiman@redhat.com>
---
 tests/vhost-user-bridge.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Maxime Coquelin July 12, 2017, 2:57 p.m. UTC | #1 
On 07/12/2017 11:41 AM, Jens Freimann wrote:
> From: Jens Freimann <jfreiman@redhat.com>
> 
> vhost-user-bridge prints out a lot of information, including dumps
> of all transmitted data. When called from a testcase this output
> clutters the actual test results, so let's make the default no debug
> output.
> 
> Signed-off-by: Jens Freimann <jfreiman@redhat.com>
> ---
>   tests/vhost-user-bridge.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Makes sense to have debug logs disabled by default.

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime

> diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c
> index 1e5b5ca..93d9535 100644
> --- a/tests/vhost-user-bridge.c
> +++ b/tests/vhost-user-bridge.c
> @@ -34,7 +34,7 @@
>   #include "standard-headers/linux/virtio_net.h"
>   #include "contrib/libvhost-user/libvhost-user.h"
>   
> -#define VHOST_USER_BRIDGE_DEBUG 1
> +#define VHOST_USER_BRIDGE_DEBUG 0
>   
>   #define DPRINT(...) \
>       do { \
>
diff mbox

Patch

diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c
index 1e5b5ca..93d9535 100644
--- a/tests/vhost-user-bridge.c
+++ b/tests/vhost-user-bridge.c
@@ -34,7 +34,7 @@ 
 #include "standard-headers/linux/virtio_net.h"
 #include "contrib/libvhost-user/libvhost-user.h"
 
-#define VHOST_USER_BRIDGE_DEBUG 1
+#define VHOST_USER_BRIDGE_DEBUG 0
 
 #define DPRINT(...) \
     do { \