From patchwork Tue Aug 29 17:32:26 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pranith Kumar X-Patchwork-Id: 9927815 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A5062603B4 for ; Tue, 29 Aug 2017 17:33:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9243E28919 for ; Tue, 29 Aug 2017 17:33:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 84687289D2; Tue, 29 Aug 2017 17:33:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1DB282898D for ; Tue, 29 Aug 2017 17:33:31 +0000 (UTC) Received: from localhost ([::1]:46293 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dmkOI-00027K-Qo for patchwork-qemu-devel@patchwork.kernel.org; Tue, 29 Aug 2017 13:33:30 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37236) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dmkNP-00025d-ER for qemu-devel@nongnu.org; Tue, 29 Aug 2017 13:32:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dmkNO-0005as-Lp for qemu-devel@nongnu.org; Tue, 29 Aug 2017 13:32:35 -0400 Received: from mail-yw0-x241.google.com ([2607:f8b0:4002:c05::241]:34149) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dmkNI-0005ZY-Nt; Tue, 29 Aug 2017 13:32:28 -0400 Received: by mail-yw0-x241.google.com with SMTP id h127so2497739ywf.1; Tue, 29 Aug 2017 10:32:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=QE8qVzZ6qug7v2sp4lilVZoojLLBjVQrsluNDtshDK8=; b=l2Rqav9DGTDRgmG0uVeWKow3p93Ps4E2Wop54gudweIzYfOhRyZCgOYlTNCiAC07G+ Yjy3m1kT8b8bNYmE5/FXThrfcS9SNMIBGmWWDoahx5S12BDi0rS09vFrdVMYffGOE4Y6 Ig0D6iq2kV8gxlvgORDX5VrxGh6NrGpdR71CzSRrlhaTtAC2dS83wZ5KGYJYsR0hlISn 9Dd9mBrVsyQsDfTRfXfW09J24WfmZ8u/5vFspLsICv4U5qpJ83AqoOV7P4jbR2cpQjAS lGhFwXrTnIQPYa9W6+o0xE4+rIOCaSI5noGtb/rRIzh5hiK2Lqa+gBObMH2meDrY0Gwv vAqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=QE8qVzZ6qug7v2sp4lilVZoojLLBjVQrsluNDtshDK8=; b=oD8FNLxLKMEJHBUgJHJrYOSW1/pZX5HFIqpJ7cPJjKW31Jh6cbrx2z2FNLhaPmxNqN 9YjFg2eiJMH5T44BsMypTGznrXUpetPpXlJshl0+/dIO51E3KGlRP5Y0DOLBgWRRPs4z Wy4mv2R9eBnuUPIyKc3FtfKjeI/ZCA6regsHlg0alIDgioqB6ZiyISICcK7L1Z5Y44IC rGDwqiWn8kveiH7e3pz6TqibqLrPzgibl4utlUQ2dmm4LnC6hxKcTvIW550D1XLLC7lE fITZcrUdfeAJ9YVyDd7uFkng0HjMmHwUzQVZewLOKF7a2Dvw2gGwyzE0RsR6lPE0ftYM QHNg== X-Gm-Message-State: AHYfb5gZKX45tIbRxCBuURWJk2MSAz894H0va4ElB6WICZghJZ9r6usW YdPJXRzM6Cq1GZe6pew= X-Received: by 10.129.166.196 with SMTP id d187mr1088557ywh.353.1504027947905; Tue, 29 Aug 2017 10:32:27 -0700 (PDT) Received: from localhost.localdomain ([98.192.46.210]) by smtp.gmail.com with ESMTPSA id n77sm1259513ywd.42.2017.08.29.10.32.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Aug 2017 10:32:27 -0700 (PDT) From: Pranith Kumar To: Peter Maydell , qemu-arm@nongnu.org (open list:ARM cores), qemu-devel@nongnu.org (open list:All patches CC here) Date: Tue, 29 Aug 2017 13:32:26 -0400 Message-Id: <20170829173226.7625-1-bobby.prani@gmail.com> X-Mailer: git-send-email 2.13.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4002:c05::241 Subject: [Qemu-devel] [PATCH] arm_gicv3_kvm: Fix compile warning X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Fix the following warning: /home/pranith/qemu/hw/intc/arm_gicv3_kvm.c:296:17: warning: logical not is only applied to the left hand side of this bitwise operator [-Wlogical-not-parentheses] if (!c->gicr_ctlr & GICR_CTLR_ENABLE_LPIS) { ^ ~ /home/pranith/qemu/hw/intc/arm_gicv3_kvm.c:296:17: note: add parentheses after the '!' to evaluate the bitwise operator first if (!c->gicr_ctlr & GICR_CTLR_ENABLE_LPIS) { ^ /home/pranith/qemu/hw/intc/arm_gicv3_kvm.c:296:17: note: add parentheses around left hand side expression to silence this warning if (!c->gicr_ctlr & GICR_CTLR_ENABLE_LPIS) { ^ Signed-off-by: Pranith Kumar --- hw/intc/arm_gicv3_kvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/intc/arm_gicv3_kvm.c b/hw/intc/arm_gicv3_kvm.c index 6051c77705..481fe5405a 100644 --- a/hw/intc/arm_gicv3_kvm.c +++ b/hw/intc/arm_gicv3_kvm.c @@ -293,7 +293,7 @@ static void kvm_arm_gicv3_put(GICv3State *s) kvm_gicr_access(s, GICR_PROPBASER + 4, ncpu, ®h, true); reg64 = c->gicr_pendbaser; - if (!c->gicr_ctlr & GICR_CTLR_ENABLE_LPIS) { + if (!(c->gicr_ctlr & GICR_CTLR_ENABLE_LPIS)) { /* Setting PTZ is advised if LPIs are disabled, to reduce * GIC initialization time. */