| Message ID | 20170905035457.3753-9-Sergio.G.DelReal@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Note that until this patch (8/14) there is no compiling. I tried to put this patch earlier in the patchset but found difficulties because some things need to be done before the hvf code compiles well. Also, the commit message needs to be updated (remove the -enable-hvf part). On Mon, Sep 4, 2017 at 10:54 PM, Sergio Andres Gomez Del Real < sergio.g.delreal@gmail.com> wrote: > This commit adds to target/i386/Makefile.objs the necessary rules so > that the new files for hvf are compiled by the build system. > It also adds handling of the -enable-hvf argument in the main function > in vl.c. > > Signed-off-by: Sergio Andres Gomez Del Real <Sergio.G.DelReal@gmail.com> > --- > target/i386/Makefile.objs | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target/i386/Makefile.objs b/target/i386/Makefile.objs > index 6a26e9d9f0..0bef89c099 100644 > --- a/target/i386/Makefile.objs > +++ b/target/i386/Makefile.objs > @@ -12,4 +12,5 @@ obj-$(CONFIG_HAX) += hax-all.o hax-mem.o hax-windows.o > endif > ifdef CONFIG_DARWIN > obj-$(CONFIG_HAX) += hax-all.o hax-mem.o hax-darwin.o > +obj-$(CONFIG_HVF) += hvf-utils/ hvf-all.o > endif > -- > 2.14.1 > >
Stefan, is this acceptable? I mean delaying the compiling; up until patch 7 no hvf code is compiled. Or should I just squash everything from patch 2 to 7? El 4/09/2017 23:03, "Sergio Andrés Gómez del Real" < sergio.g.delreal@gmail.com> escribió: Note that until this patch (8/14) there is no compiling. I tried to put this patch earlier in the patchset but found difficulties because some things need to be done before the hvf code compiles well. Also, the commit message needs to be updated (remove the -enable-hvf part). On Mon, Sep 4, 2017 at 10:54 PM, Sergio Andres Gomez Del Real < sergio.g.delreal@gmail.com> wrote: > This commit adds to target/i386/Makefile.objs the necessary rules so > that the new files for hvf are compiled by the build system. > It also adds handling of the -enable-hvf argument in the main function > in vl.c. > > Signed-off-by: Sergio Andres Gomez Del Real <Sergio.G.DelReal@gmail.com> > --- > target/i386/Makefile.objs | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target/i386/Makefile.objs b/target/i386/Makefile.objs > index 6a26e9d9f0..0bef89c099 100644 > --- a/target/i386/Makefile.objs > +++ b/target/i386/Makefile.objs > @@ -12,4 +12,5 @@ obj-$(CONFIG_HAX) += hax-all.o hax-mem.o hax-windows.o > endif > ifdef CONFIG_DARWIN > obj-$(CONFIG_HAX) += hax-all.o hax-mem.o hax-darwin.o > +obj-$(CONFIG_HVF) += hvf-utils/ hvf-all.o > endif > -- > 2.14.1 > >
On Tue, Sep 05, 2017 at 08:12:31PM -0500, Sergio Andrés Gómez del Real wrote: > Stefan, is this acceptable? I mean delaying the compiling; up until patch 7 > no hvf code is compiled. Or should I just squash everything from patch 2 to > 7? It's okay. Feel free to delay until patch 7 for now. There is value in importing code verbatim and making changes in separate patches. That way it's easy to diff the code against the upstream source to verify that it was imported correctly. Stefan
diff --git a/target/i386/Makefile.objs b/target/i386/Makefile.objs index 6a26e9d9f0..0bef89c099 100644 --- a/target/i386/Makefile.objs +++ b/target/i386/Makefile.objs @@ -12,4 +12,5 @@ obj-$(CONFIG_HAX) += hax-all.o hax-mem.o hax-windows.o endif ifdef CONFIG_DARWIN obj-$(CONFIG_HAX) += hax-all.o hax-mem.o hax-darwin.o +obj-$(CONFIG_HVF) += hvf-utils/ hvf-all.o endif
This commit adds to target/i386/Makefile.objs the necessary rules so that the new files for hvf are compiled by the build system. It also adds handling of the -enable-hvf argument in the main function in vl.c. Signed-off-by: Sergio Andres Gomez Del Real <Sergio.G.DelReal@gmail.com> --- target/i386/Makefile.objs | 1 + 1 file changed, 1 insertion(+)