diff mbox

[v9,6/6] qemu-iotests: add 184 for throttle filter driver

Message ID 20170905161643.GO4633@localhost.localdomain (mailing list archive)
State New, archived
Headers show

Commit Message

Kevin Wolf Sept. 5, 2017, 4:16 p.m. UTC 
Am 25.08.2017 um 15:20 hat Manos Pitsidianakis geschrieben:
> Reviewed-by: Alberto Garcia <berto@igalia.com>
> Signed-off-by: Manos Pitsidianakis <el13635@mail.ntua.gr>

Does this test actually (still) pass for you? I can't see that it's
related to any recent change in master, but this is the diff that I get.

I can update the reference output while applying, but obviously if it's
currently passing for you, it will fail after I "fix" it.

Kevin


184                [18:07:39] [18:07:39] - output mismatch (see 184.out.bad)

Comments

Kevin Wolf Sept. 5, 2017, 7:06 p.m. UTC | #1 
Am 05.09.2017 um 18:16 hat Kevin Wolf geschrieben:
> Am 25.08.2017 um 15:20 hat Manos Pitsidianakis geschrieben:
> > Reviewed-by: Alberto Garcia <berto@igalia.com>
> > Signed-off-by: Manos Pitsidianakis <el13635@mail.ntua.gr>
> 
> Does this test actually (still) pass for you? I can't see that it's
> related to any recent change in master, but this is the diff that I get.
> 
> I can update the reference output while applying, but obviously if it's
> currently passing for you, it will fail after I "fix" it.

For the record, we discussed this on IRC. The test works correctly on
master, but on my block branch there is a conflict with "block: pass
bdrv_* methods to bs->file by default in block filters".

The correct action is to merge this throttle driver series after the
conflicting patch because throttle doesn't implement .bdrv_get_info and
needs the forwarding that the other patch implements.

I updated the test output accordingly and applied the series to my block
branch.

Kevin
diff mbox

Patch

--- /home/kwolf/source/qemu/tests/qemu-iotests/184.out  2017-09-05 18:07:30.751340633 +0200
+++ 184.out.bad 2017-09-05 18:07:39.707341854 +0200
@@ -30,8 +30,10 @@ 
             "image": {
                 "virtual-size": 67108864,
                 "filename": "json:{\"throttle-group\": \"group0\", \"driver\": \"throttle\", \"file\": {\"driver\": \"qcow2\", \"file\": {\"driver\": \"file\", \"filename\": \"TEST_DIR/t.qcow2\"}}}",
+                "cluster-size": 65536,
                 "format": "throttle",
-                "actual-size": 200704
+                "actual-size": 200704,
+                "dirty-flag": false
             },
             "iops_wr": 0,
             "ro": false,