From patchwork Mon Oct 16 17:25:29 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 10009455 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0169F601D5 for ; Mon, 16 Oct 2017 17:42:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E60BF285E0 for ; Mon, 16 Oct 2017 17:42:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DB26328689; Mon, 16 Oct 2017 17:42:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 43688285E0 for ; Mon, 16 Oct 2017 17:42:38 +0000 (UTC) Received: from localhost ([::1]:34356 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e49PR-0006MO-8y for patchwork-qemu-devel@patchwork.kernel.org; Mon, 16 Oct 2017 13:42:37 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52283) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e499p-00020a-GA for qemu-devel@nongnu.org; Mon, 16 Oct 2017 13:26:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e499o-0003Op-Gp for qemu-devel@nongnu.org; Mon, 16 Oct 2017 13:26:29 -0400 Received: from mail-pg0-x234.google.com ([2607:f8b0:400e:c05::234]:51119) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e499o-0003OF-BR for qemu-devel@nongnu.org; Mon, 16 Oct 2017 13:26:28 -0400 Received: by mail-pg0-x234.google.com with SMTP id y7so7342099pgb.7 for ; Mon, 16 Oct 2017 10:26:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=14UnMYMoZqmrJ9oz6osYwF58UTet1QjRnDjyBDt55ag=; b=As0pz48359ajQ6Ug9EXlJEMwQrr+/sBS2QWjxNai+8p5WVwOfF/3fhxDhd/KPcwzyt cWCxYnHDyAMA1I1wR8su2o/xtzhG4R8Czl3zkg0nSRbBH8v/Jj1AgL0kBSjehiIdz6us y8Imv7uxHkCYAxQuD+ZTCX1xHefxk52O13iMk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=14UnMYMoZqmrJ9oz6osYwF58UTet1QjRnDjyBDt55ag=; b=C+ufwKSvNESbtYGEZuDZ1xO1r5P2w0Ih2hgT19R+GMgkvKJNyJzEzcf9bl34RzhNBN lIA36VjVSI18BA7n5woZCky5cRpwyUu3E1UMBbABND/hBcrSlDcQE2U5DFzp2JTLONmX 6pkklOCCa+6rL5qesImLY+rbpp80nuOW+DvqKDOuiokitlYo8FYktjzn97YrRbY62Leo TTBiORMN+ag5kivSexfWOwKo6v8QefmGGsyKYNnRDWXijmD7tNu+yiy+ylc4dL1Voh76 HvebcZ7EHC4BPbeGTuB4SJ2GS+YnrD2JhI4vtDwSeRlfKF/iUAhsIWQekIyop2tjh0U7 7qbw== X-Gm-Message-State: AMCzsaXMfjtUMc5FQCHT5CpcbaIG6mOhpqb4sXVYQz05IVhR7UoQarZa klk+O1zmZ8ixVAgi+Dmjjpf5cMISRpU= X-Google-Smtp-Source: AOwi7QCNegFNvChZ1UiFH9u0w7h60vCqBUCeCCRnDWwYOAsV4p3oDLl8Phm4hNZNwg+khhZZQk0W5g== X-Received: by 10.84.135.101 with SMTP id 92mr9657204pli.180.1508174787215; Mon, 16 Oct 2017 10:26:27 -0700 (PDT) Received: from cloudburst.twiddle.net (97-126-104-76.tukw.qwest.net. [97.126.104.76]) by smtp.gmail.com with ESMTPSA id i187sm5594249pfc.96.2017.10.16.10.26.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Oct 2017 10:26:26 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 16 Oct 2017 10:25:29 -0700 Message-Id: <20171016172609.23422-11-richard.henderson@linaro.org> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20171016172609.23422-1-richard.henderson@linaro.org> References: <20171016172609.23422-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::234 Subject: [Qemu-devel] [PATCH v6 10/50] tcg: Avoid loops against variable bounds X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cota@braap.org, Richard Henderson Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Richard Henderson Copy s->nb_globals or s->nb_temps to a local variable for the purposes of iteration. This should allow the compiler to use low-overhead looping constructs on some hosts. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson Reviewed-by: Emilio G. Cota --- tcg/tcg.c | 27 ++++++++++----------------- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index 719db9f2b6..bb342e06dd 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -1166,23 +1166,16 @@ void tcg_gen_callN(TCGContext *s, void *func, TCGArg ret, static void tcg_reg_alloc_start(TCGContext *s) { - int i; + int i, n; TCGTemp *ts; - for(i = 0; i < s->nb_globals; i++) { + + for (i = 0, n = s->nb_globals; i < n; i++) { ts = &s->temps[i]; - if (ts->fixed_reg) { - ts->val_type = TEMP_VAL_REG; - } else { - ts->val_type = TEMP_VAL_MEM; - } + ts->val_type = (ts->fixed_reg ? TEMP_VAL_REG : TEMP_VAL_MEM); } - for(i = s->nb_globals; i < s->nb_temps; i++) { + for (n = s->nb_temps; i < n; i++) { ts = &s->temps[i]; - if (ts->temp_local) { - ts->val_type = TEMP_VAL_MEM; - } else { - ts->val_type = TEMP_VAL_DEAD; - } + ts->val_type = (ts->temp_local ? TEMP_VAL_MEM : TEMP_VAL_DEAD); ts->mem_allocated = 0; ts->fixed_reg = 0; } @@ -2284,9 +2277,9 @@ static void temp_save(TCGContext *s, TCGTemp *ts, TCGRegSet allocated_regs) temporary registers needs to be allocated to store a constant. */ static void save_globals(TCGContext *s, TCGRegSet allocated_regs) { - int i; + int i, n; - for (i = 0; i < s->nb_globals; i++) { + for (i = 0, n = s->nb_globals; i < n; i++) { temp_save(s, &s->temps[i], allocated_regs); } } @@ -2296,9 +2289,9 @@ static void save_globals(TCGContext *s, TCGRegSet allocated_regs) temporary registers needs to be allocated to store a constant. */ static void sync_globals(TCGContext *s, TCGRegSet allocated_regs) { - int i; + int i, n; - for (i = 0; i < s->nb_globals; i++) { + for (i = 0, n = s->nb_globals; i < n; i++) { TCGTemp *ts = &s->temps[i]; tcg_debug_assert(ts->val_type != TEMP_VAL_REG || ts->fixed_reg