From patchwork Thu Oct 26 10:50:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 10027967 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 21CD36032C for ; Thu, 26 Oct 2017 10:54:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0BD11274D1 for ; Thu, 26 Oct 2017 10:54:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F3E0028179; Thu, 26 Oct 2017 10:54:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6CC16274D1 for ; Thu, 26 Oct 2017 10:54:25 +0000 (UTC) Received: from localhost ([::1]:52054 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e7fns-0001vw-L7 for patchwork-qemu-devel@patchwork.kernel.org; Thu, 26 Oct 2017 06:54:24 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56471) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e7fjz-0007rx-4e for qemu-devel@nongnu.org; Thu, 26 Oct 2017 06:50:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e7fjt-0002kW-3K for qemu-devel@nongnu.org; Thu, 26 Oct 2017 06:50:23 -0400 Received: from mail-wr0-x242.google.com ([2a00:1450:400c:c0c::242]:51912) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e7fjs-0002k1-SJ for qemu-devel@nongnu.org; Thu, 26 Oct 2017 06:50:17 -0400 Received: by mail-wr0-x242.google.com with SMTP id j15so2718646wre.8 for ; Thu, 26 Oct 2017 03:50:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=JN2AyJCk5mT/ku4Ut7yvcJVUiHrhygGV3xXVcJrmdvI=; b=MNTk6lbnyVJTUHqI5MlVOEQIYRXI5o2n5kX/sCWj+HSwpvYbFmwUE3vBBN+G/pXbSp Yd19onl7iQ6GG2IMbmSU/sFeUodlqP9r0+VrnOOSdW4EC+ids/7RmdtYpoTo/c5NAKsN Wxf/vFpcZ1alZSqwFnAXl2ig6SijVDxZRNs2w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=JN2AyJCk5mT/ku4Ut7yvcJVUiHrhygGV3xXVcJrmdvI=; b=soUDr/+HtnJlFiY9Sg1d2Hm0mFqCcQJxsa+BUFPV8kxCceor8krMNsL847aZtHEvhQ O7w5itghNjhrahTJSSD8M9sMROQpenU5BwbE0oWhgQpoVFYbu3aIqy+TKVLsbyvChbqC s7MYkaux8MnhF33pZOoRrQFqwpDhuAFzlGrsWP9BediM19tRFEmCBPG8duUu+eaqxkT0 OZBxkgb3VE8fMqvllosABn3gygocM1Wnqr7zCN8CGpHcNzTZA3sgUBjUl11EwYOyi0+4 CScTUSWaKLUtcAyhJ8iANKkjnp4XlRZLfd6TWxcicSYwvQJs8B9M/n/zGezetaD/dY9U nQTA== X-Gm-Message-State: AMCzsaW/yQEti+Ek/nvjv5vC2R9kV3PMoW0ojowWYx1urpxruVqvhJht Tgv4awvYclyaCeF4YzhxmmIvClysoag= X-Google-Smtp-Source: ABhQp+T9o9KN8TQL1x0Nhml/lAt16BEGruqg1VJedj48IMsQcLqvbP4MiG5Q+ytqCFGVmMy6XH7nmw== X-Received: by 10.223.139.10 with SMTP id n10mr5239586wra.156.1509015015586; Thu, 26 Oct 2017 03:50:15 -0700 (PDT) Received: from cloudburst.twiddle.net ([62.168.35.124]) by smtp.gmail.com with ESMTPSA id p128sm924484wmb.1.2017.10.26.03.50.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 26 Oct 2017 03:50:14 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 26 Oct 2017 12:50:07 +0200 Message-Id: <20171026105007.31777-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20171026105007.31777-1-richard.henderson@linaro.org> References: <20171026105007.31777-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::242 Subject: [Qemu-devel] [PATCH v2 4/4] target/i386: Fix ANDN (bmi) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, Richard Henderson , ehabkost@redhat.com, Ricardo Ribalda Delgado Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Ricardo Ribalda Delgado Operands on ANDN are swapped. Tested with the following function: long test_andn(long v1, long v2){ return (~v1 & v2); } Compiled with: gcc kk.c -mbmi -O3 -Wall 0000000000000910 : 910:c4 e2 c0 f2 c6 andn %rsi,%rdi,%rax 915:c3 retq 916:66 2e 0f 1f 84 00 00 nopw %cs:0x0(%rax,%rax,1) 91d:00 00 00 and gcc kk.c -march=native -O3 -Wall 0000000000000930 : 930: 48 f7 d7 not %rdi 933: 48 89 f8 mov %rdi,%rax 936: 48 21 f0 and %rsi,%rax 939: c3 retq 93a: 66 0f 1f 44 00 00 nopw 0x0(%rax,%rax,1) The test showed than -mbmi version behaved differently than the -march native version. Signed-off-by: Ricardo Ribalda Delgado Message-Id: <20170713215137.5307-1-ricardo.ribalda@gmail.com> Signed-off-by: Richard Henderson --- target/i386/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/translate.c b/target/i386/translate.c index dd464b98b0..96cd04c6de 100644 --- a/target/i386/translate.c +++ b/target/i386/translate.c @@ -3810,7 +3810,7 @@ static void gen_sse(CPUX86State *env, DisasContext *s, int b, } ot = mo_64_32(s->dflag); gen_ldst_modrm(env, s, modrm, ot, OR_TMP0, 0); - tcg_gen_andc_tl(cpu_T0, cpu_regs[s->vex_v], cpu_T0); + tcg_gen_andc_tl(cpu_T0, cpu_T0, cpu_regs[s->vex_v]); gen_op_mov_reg_v(ot, reg, cpu_T0); gen_op_update1_cc(); set_cc_op(s, CC_OP_LOGICB + ot);