From patchwork Fri Nov 3 00:01:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Francisco Iglesias X-Patchwork-Id: 10039391 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 27AFE6032D for ; Fri, 3 Nov 2017 00:05:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 17FC028CF5 for ; Fri, 3 Nov 2017 00:05:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0A16C28DFA; Fri, 3 Nov 2017 00:05:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B88BD28CF5 for ; Fri, 3 Nov 2017 00:05:44 +0000 (UTC) Received: from localhost ([::1]:34279 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eAPUV-0002ej-Tk for patchwork-qemu-devel@patchwork.kernel.org; Thu, 02 Nov 2017 20:05:43 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48481) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eAPQQ-0008Qn-GM for qemu-devel@nongnu.org; Thu, 02 Nov 2017 20:01:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eAPQP-0000u1-LA for qemu-devel@nongnu.org; Thu, 02 Nov 2017 20:01:30 -0400 Received: from mail-lf0-x241.google.com ([2a00:1450:4010:c07::241]:47375) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eAPQP-0000tf-Dx for qemu-devel@nongnu.org; Thu, 02 Nov 2017 20:01:29 -0400 Received: by mail-lf0-x241.google.com with SMTP id k40so1309101lfi.4 for ; Thu, 02 Nov 2017 17:01:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Kd3Ts2sK0qM5EZrgstgg3un17UPdc18uEXx8/KI/71Y=; b=FME1AFcDlbd5sC3QDNdXOmDnRqt4J7nh8PuILMEQSrLH1Rf80Rmpo7EwXaCmaER+T/ A6//LA1BbcR1sNSc0YgysNDeZ/dzptinDYkYCte1E8WVVpcHLrtYNQbpCTtGa62YMoP/ OlZw6xVg2S710b4QwB1mLt5k3PGCm0VogmJ2as+tNtjm9cvXZVsAxh9L7tKkSnaBI5Dk N8bAz7ffCIcTdicQhNwrR/5t4TmuGFMuQFRo6dlVUkEur4npA03GEZ99XCkpches5kwF 1FxSx+ai93MiPQ3uhTzAUIT2onQUBAr/Op/ZzcpeJOBjw9xK0IIdIAeH8nQj8LfBVe6S 6RkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Kd3Ts2sK0qM5EZrgstgg3un17UPdc18uEXx8/KI/71Y=; b=nc3PElNlr4k/3RWI6Kk5xC7sObaArne1BI1PmMKi8X9shkWIEWlXR7m0yXzVI1Vh7m Cqte4Z6PBKwb5JK7PHYtisx755Y0tx88XnVLje2adShZCAVgk7OkVfqp5TYzPeQHML+F UZfDyH1TR/pBBITLUkr4RXE/PEM8DfEU2wuOs/sEZMhC3DSSMhS9z0EzAcvYFdIbNN7X bq60luKs33cLDhK9M21rAANDr1RW14ISrVenFJRrSVsNID/yHyDEuFtrzWvrFUzUwAU+ WYKYKG2iB86GD5KVLoPp2zohUuciPw04CAnNMLLjmFgIHyda6kvLnVMneqE8gabYl1XQ l7oQ== X-Gm-Message-State: AJaThX6/iMg88MyBdTqNxKcZSgVwItfbFySE2MOmbEF4WiJ21A8CYaNm ildFYn4CiVGlBGIr6tzdpuyc+w== X-Google-Smtp-Source: ABhQp+RbtH75O9KYdIpUm7LNytMpG+22EBWIs/7Uo8bF7Wvrvx4qFgtpqx1pXXTG8hRinrVlC1ChmA== X-Received: by 10.25.59.26 with SMTP id i26mr1628384lfa.191.1509667287854; Thu, 02 Nov 2017 17:01:27 -0700 (PDT) Received: from localhost.localdomain (c83-254-152-225.bredband.comhem.se. [83.254.152.225]) by smtp.gmail.com with ESMTPSA id m27sm937278lje.21.2017.11.02.17.01.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Nov 2017 17:01:26 -0700 (PDT) From: Francisco Iglesias To: qemu-devel@nongnu.org Date: Fri, 3 Nov 2017 01:01:07 +0100 Message-Id: <20171103000109.28244-12-frasse.iglesias@gmail.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20171103000109.28244-1-frasse.iglesias@gmail.com> References: <20171103000109.28244-1-frasse.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::241 Subject: [Qemu-devel] [PATCH v7 11/13] xilinx_spips: Don't set TX FIFO UNDERFLOW at cmd done X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, edgari@xilinx.com, alistai@xilinx.com, francisco.iglesias@feimtech.se, mar.krzeminski@gmail.com Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Don't set TX FIFO UNDERFLOW interrupt after done transmiting the commands. Also update interrupts after reading out the interrupt status. Signed-off-by: Francisco Iglesias Acked-by: Alistair Francis --- hw/ssi/xilinx_spips.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c index 7f0f317..159a89d 100644 --- a/hw/ssi/xilinx_spips.c +++ b/hw/ssi/xilinx_spips.c @@ -329,9 +329,6 @@ static void xilinx_spips_flush_txfifo(XilinxSPIPS *s) uint8_t addr_length; if (fifo8_is_empty(&s->tx_fifo)) { - if (!(s->regs[R_LQSPI_CFG] & LQSPI_CFG_LQ_MODE)) { - s->regs[R_INTR_STATUS] |= IXR_TX_FIFO_UNDERFLOW; - } xilinx_spips_update_ixr(s); return; } else if (s->snoop_state == SNOOP_STRIPING) { @@ -530,6 +527,7 @@ static uint64_t xilinx_spips_read(void *opaque, hwaddr addr, ret = s->regs[addr] & IXR_ALL; s->regs[addr] = 0; DB_PRINT_L(0, "addr=" TARGET_FMT_plx " = %x\n", addr * 4, ret); + xilinx_spips_update_ixr(s); return ret; case R_INTR_MASK: mask = IXR_ALL;