From patchwork Mon Nov 6 15:47:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 10043759 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 90D55603FF for ; Mon, 6 Nov 2017 15:54:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7A5F429E0A for ; Mon, 6 Nov 2017 15:54:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6D98B29E17; Mon, 6 Nov 2017 15:54:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E08CD29E0A for ; Mon, 6 Nov 2017 15:54:55 +0000 (UTC) Received: from localhost ([::1]:48791 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBjji-00032e-Q9 for patchwork-qemu-devel@patchwork.kernel.org; Mon, 06 Nov 2017 10:54:54 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33458) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBjdi-00078j-GF for qemu-devel@nongnu.org; Mon, 06 Nov 2017 10:48:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eBjdf-0000Rx-Oh for qemu-devel@nongnu.org; Mon, 06 Nov 2017 10:48:42 -0500 Received: from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244]:48203) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eBjde-0000QV-0Q; Mon, 06 Nov 2017 10:48:38 -0500 Received: by mail-pg0-x244.google.com with SMTP id v78so8513014pgb.5; Mon, 06 Nov 2017 07:48:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XJlfyebN1xeOK575CC0qYGfAM4pk4xf2XoJ3QxQde7o=; b=bUYjupTc7mPoquFC6AIF0gRmtlhXSMkgud4tnN89lZqIYbnUaQWjsGl6bjUSYehlTK wZe294nO4H8Y+VIotGXzf66kLNZaZ1qHSivVPzJTdMp11gNbmO7LMzlVctyEMqvvXi8n fiEV1ot1NKDxXfaD/ySeqsio9B8cPnEhejiD5cdssuLOWUKo2EHuwBrzqvA/muG11ZPk dOg9V2i8MXqzdRlGaRNF0JuPsLeTbate1nr2vO+TjI+5wjYFLcM/1IBZMOcQjDKf3IpF R83gaev3nsyDvB8oolQQ0+fMUtnEfbzXfrgw83seCFWjuvRBD8lbP6jqRZdd6LOcl1L6 T9DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XJlfyebN1xeOK575CC0qYGfAM4pk4xf2XoJ3QxQde7o=; b=FkxtmT+UjVs9iv1T0vHctAjb6n6sJ0XoEhc1lJcsXKs+sU2tW11YPvsClFBOZVft8S 3+gh7Z0scOlDNl//spWgsTT79AOCRK049/RKj0oIA0DX2CQdImXBal2uyj5rPaUC0tA2 n30KWBbSsA97Od/n5WG6j2REJmr8n0a0iroUpTdxLt4RxJgk/g0JFrcRmzJjJRd9DOhG PlMvHOBWenWwssJvfA7rWg6jzwZmQ70kQwyJ9YBOSxjSN72UFzqwg32tPZDOXic+UwlN k4FkKHidddmXLT5Br3ZUUFxcZUtuqPxZOi9wU+KPLlvB1ewkWnoG8nDc7/2IEgg4++ok OEEg== X-Gm-Message-State: AMCzsaWmYPYGVFl1PbGwnxExGCw0dXDZcCAi/HGu4TG9/YlKVw28yWs/ ypjAqWhZrP220wDNPEBqFaaRa8nRIAI= X-Google-Smtp-Source: ABhQp+SYWQ2Qe42gr8UQQEYpwpGsoRsTcdBVuVtv8tup791IexwAn48Z/iJlw36gwaeSRNnX7FnnEQ== X-Received: by 10.98.156.207 with SMTP id u76mr17090839pfk.211.1509983316661; Mon, 06 Nov 2017 07:48:36 -0800 (PST) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id x1sm22719590pfh.113.2017.11.06.07.48.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Nov 2017 07:48:36 -0800 (PST) From: Andrey Smirnov To: qemu-arm@nongnu.org Date: Mon, 6 Nov 2017 07:47:51 -0800 Message-Id: <20171106154813.19936-9-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20171106154813.19936-1-andrew.smirnov@gmail.com> References: <20171106154813.19936-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::244 Subject: [Qemu-devel] [PATCH v3 08/30] imx_fec: Use correct length for packet size X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Andrey Smirnov , Jason Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, yurovsky@gmail.com Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Use 'frame_size' instead of 'len' when calling qemu_send_packet(), failing to do so results in malformed packets send in case when that packed is fragmented into multiple DMA transactions. Cc: Peter Maydell Cc: Jason Wang Cc: Philippe Mathieu-Daudé Cc: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org Cc: yurovsky@gmail.com Reviewed-by: Peter Maydell Signed-off-by: Andrey Smirnov --- hw/net/imx_fec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c index 38d8c27dcd..eefb3b2c62 100644 --- a/hw/net/imx_fec.c +++ b/hw/net/imx_fec.c @@ -528,7 +528,7 @@ static void imx_enet_do_tx(IMXFECState *s, uint32_t index) } } /* Last buffer in frame. */ - qemu_send_packet(qemu_get_queue(s->nic), frame, len); + qemu_send_packet(qemu_get_queue(s->nic), frame, frame_size); ptr = frame; frame_size = 0; if (bd.option & ENET_BD_TX_INT) {