From patchwork Thu Nov 16 02:28:32 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mao Zhongyi X-Patchwork-Id: 10060585 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4FA286019D for ; Thu, 16 Nov 2017 02:33:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2FD102A5B7 for ; Thu, 16 Nov 2017 02:33:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 248AC2A5BE; Thu, 16 Nov 2017 02:33:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B2C252A5BC for ; Thu, 16 Nov 2017 02:33:28 +0000 (UTC) Received: from localhost ([::1]:38655 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eF9zb-0002Ui-N3 for patchwork-qemu-devel@patchwork.kernel.org; Wed, 15 Nov 2017 21:33:27 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46696) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eF9yt-0002UZ-PZ for qemu-devel@nongnu.org; Wed, 15 Nov 2017 21:32:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eF9yq-0001mm-MR for qemu-devel@nongnu.org; Wed, 15 Nov 2017 21:32:43 -0500 Received: from mail.cn.fujitsu.com ([183.91.158.132]:32595 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eF9yq-0001ky-BV for qemu-devel@nongnu.org; Wed, 15 Nov 2017 21:32:40 -0500 X-IronPort-AV: E=Sophos;i="5.43,368,1503331200"; d="scan'208";a="30214457" Received: from localhost (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 16 Nov 2017 10:32:33 +0800 Received: from G08CNEXCHPEKD02.g08.fujitsu.local (unknown [10.167.33.83]) by cn.fujitsu.com (Postfix) with ESMTP id 6C25E41860C2; Thu, 16 Nov 2017 10:32:28 +0800 (CST) Received: from localhost.localdomain (10.167.226.123) by G08CNEXCHPEKD02.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server (TLS) id 14.3.361.1; Thu, 16 Nov 2017 10:32:28 +0800 From: Mao Zhongyi To: Date: Thu, 16 Nov 2017 10:28:32 +0800 Message-ID: <20171116022832.24894-1-maozy.fnst@cn.fujitsu.com> X-Mailer: git-send-email 2.9.4 MIME-Version: 1.0 X-Originating-IP: [10.167.226.123] X-yoursite-MailScanner-ID: 6C25E41860C2.A1900 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: maozy.fnst@cn.fujitsu.com X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 183.91.158.132 Subject: [Qemu-devel] [PATCH] colo-compare: fix the dangerous assignment X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Jason Wang , Paolo Bonzini , Li Zhijian , Zhang Chen Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Cc: Peter Maydell Cc: Jason Wang Cc: Zhang Chen Cc: Li Zhijian Cc: Paolo Bonzini Fixes: 8ec14402029d783720f4312ed8a925548e1dad61 Reported-by: Peter Maydell Reported-by: Paolo Bonzini Signed-off-by: Mao Zhongyi Reviewed-by: Darren Kenny --- net/colo-compare.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index ccdcba2..1ce195f 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@ -179,7 +179,7 @@ static int packet_enqueue(CompareState *s, int mode, Connection **con) "drop packet"); } } - con = &conn; + *con = conn; return 0; }